[GitHub] [celix] PengZheng commented on a diff in pull request #494: Remove buffer mechanism from websocket pubsub admin, make similar to tcp admin

["PengZheng (via GitHub)" <gi...@apache.org>]

PengZheng commented on code in PR #494:
URL: https://github.com/apache/celix/pull/494#discussion_r1127714233


##########
bundles/pubsub/pubsub_admin_websocket/src/pubsub_websocket_topic_receiver.c:
##########
@@ -68,6 +64,8 @@ struct pubsub_websocket_topic_receiver {
     celix_bundle_context_t *ctx;
     celix_log_helper_t *logHelper;
     void *admin;
+    size_t timeout;

Review Comment:
   I suggest `timeoutNs`, which will make comment below unnecessary.



##########
bundles/pubsub/pubsub_admin_websocket/src/pubsub_websocket_topic_receiver.c:
##########
@@ -150,15 +146,18 @@ pubsub_websocket_topic_receiver_t* pubsub_websocketTopicReceiver_create(celix_bu
 
     receiver->uri = psa_websocket_createURI(scope, topic);
 
+    // Set receiver connection thread timeout.
+    // property is in ms, timeout value in us. (convert ms to us).
+    receiver->timeout = celix_bundleContext_getPropertyAsLong(ctx, PSA_WEBSOCKET_SUBSCRIBER_CONNECTION_TIMEOUT,

Review Comment:
   `size_t` is unsigned.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org