You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sk...@apache.org on 2005/11/30 01:45:50 UTC
svn commit: r349852 - /myfaces/build/trunk/build.xml
Author: skitching
Date: Tue Nov 29 16:45:46 2005
New Revision: 349852
URL: http://svn.apache.org/viewcvs?rev=349852&view=rev
Log:
Validate generated DTD files
Modified:
myfaces/build/trunk/build.xml
Modified: myfaces/build/trunk/build.xml
URL: http://svn.apache.org/viewcvs/myfaces/build/trunk/build.xml?rev=349852&r1=349851&r2=349852&view=diff
==============================================================================
--- myfaces/build/trunk/build.xml (original)
+++ myfaces/build/trunk/build.xml Tue Nov 29 16:45:46 2005
@@ -723,6 +723,16 @@
location="${tlddoc.dtd}"/>
</xmlcatalog>
</xslt>
+
+ <xmlvalidate failonerror="true">
+ <fileset dir="${resolved-tlds.dir}">
+ <include name="*.tld"/>
+ </fileset>
+ <xmlcatalog>
+ <dtd publicid="-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
+ location="${tlddoc.dtd}"/>
+ </xmlcatalog>
+ </xmlvalidate>
</target>
<target name="legacy-tld-fix" if="tomahawk">
Re: svn commit: r349852 - /myfaces/build/trunk/build.xml [ATTN: Mike
Kienenberger]
Posted by Simon Kitching <sk...@obsidium.com>.
Hi Mike,
Mike Kienenberger wrote:
> Yeah, looks like SVN commits work differently than CVS commits in
> Subclipse. In SVN, you have to manually reselect each new file to
> commit them. How annoying.
In CVS, when a file is "added", it is immediately committed to the
repository.
However SVN has this concept of "atomic commits", where multiple changes
to a repository can happen as one transaction. So "adding" a file can't
immediately change the repository; that would give the user no chance to
group this operation with other operations.
For this reason, "svn add" just marks the new file locally. Later a
commit is done which can involve multiple files, and all changes are
within a single transaction.
But yes, when adding only one file, it does mean making two operations:
add then commit, which can be annoying.
Cheers,
Simon
Re: svn commit: r349852 - /myfaces/build/trunk/build.xml [ATTN: Mike Kienenberger]
Posted by Mike Kienenberger <mk...@gmail.com>.
Yeah, looks like SVN commits work differently than CVS commits in
Subclipse. In SVN, you have to manually reselect each new file to
commit them. How annoying.
On 11/29/05, Mike Kienenberger <mk...@gmail.com> wrote:
> Thanks, Simon.
>
> That's the third time Eclipse Subversion has claimed to commit a new
> file and failed to do so. Maybe you are correct when you say that
> the Synchronize view is defective with SVN.
>
> On 11/29/05, Simon Kitching <sk...@obsidium.com> wrote:
> > skitching@apache.org wrote:
> > > Author: skitching
> > > Date: Tue Nov 29 16:45:46 2005
> > > New Revision: 349852
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=349852&view=rev
> > > Log:
> > > Validate generated DTD files
> > >
> > > Modified:
> > > myfaces/build/trunk/build.xml
> >
> > The build.xml now validates the generated .tld file against the DTD.
> > This has shown up a mistake in recent commits re the sandbox "focus" and
> > validateCompareTo component entity references to files that don't exist.
> > As a result, the build now fails.
> >
> > Mike, if you can fix these component problems soon that would be great.
> > If nothing happens in the next few hours, I'll commit a change to the
> > sandbox tld file to comment out these components so the build at least
> > works.
> >
> > And of course the build.xml changes should prevent any such problems
> > from ever occurring in future [though it won't stop all tld generation
> > problems; I'm still waiting for feedback from the ant list re references
> > to undefined entities).
> >
> > Cheers,
> >
> > Simon
> >
> >
>
Re: svn commit: r349852 - /myfaces/build/trunk/build.xml [ATTN: Mike Kienenberger]
Posted by Mike Kienenberger <mk...@gmail.com>.
Thanks, Simon.
That's the third time Eclipse Subversion has claimed to commit a new
file and failed to do so. Maybe you are correct when you say that
the Synchronize view is defective with SVN.
On 11/29/05, Simon Kitching <sk...@obsidium.com> wrote:
> skitching@apache.org wrote:
> > Author: skitching
> > Date: Tue Nov 29 16:45:46 2005
> > New Revision: 349852
> >
> > URL: http://svn.apache.org/viewcvs?rev=349852&view=rev
> > Log:
> > Validate generated DTD files
> >
> > Modified:
> > myfaces/build/trunk/build.xml
>
> The build.xml now validates the generated .tld file against the DTD.
> This has shown up a mistake in recent commits re the sandbox "focus" and
> validateCompareTo component entity references to files that don't exist.
> As a result, the build now fails.
>
> Mike, if you can fix these component problems soon that would be great.
> If nothing happens in the next few hours, I'll commit a change to the
> sandbox tld file to comment out these components so the build at least
> works.
>
> And of course the build.xml changes should prevent any such problems
> from ever occurring in future [though it won't stop all tld generation
> problems; I'm still waiting for feedback from the ant list re references
> to undefined entities).
>
> Cheers,
>
> Simon
>
>
Re: svn commit: r349852 - /myfaces/build/trunk/build.xml [ATTN: Mike
Kienenberger]
Posted by Simon Kitching <sk...@obsidium.com>.
skitching@apache.org wrote:
> Author: skitching
> Date: Tue Nov 29 16:45:46 2005
> New Revision: 349852
>
> URL: http://svn.apache.org/viewcvs?rev=349852&view=rev
> Log:
> Validate generated DTD files
>
> Modified:
> myfaces/build/trunk/build.xml
The build.xml now validates the generated .tld file against the DTD.
This has shown up a mistake in recent commits re the sandbox "focus" and
validateCompareTo component entity references to files that don't exist.
As a result, the build now fails.
Mike, if you can fix these component problems soon that would be great.
If nothing happens in the next few hours, I'll commit a change to the
sandbox tld file to comment out these components so the build at least
works.
And of course the build.xml changes should prevent any such problems
from ever occurring in future [though it won't stop all tld generation
problems; I'm still waiting for feedback from the ant list re references
to undefined entities).
Cheers,
Simon