You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pk...@apache.org on 2026/03/30 09:46:33 UTC

(commons-build-plugin) 05/05: fix: PMD violations

This is an automated email from the ASF dual-hosted git repository.

pkarwasz pushed a commit to branch feat/slsa
in repository https://gitbox.apache.org/repos/asf/commons-build-plugin.git

commit b03478fc9793aee212062e5e2248d7a678469c0e
Author: Piotr P. Karwasz <pk...@apache.org>
AuthorDate: Mon Mar 30 11:41:28 2026 +0200

    fix: PMD violations
---
 .../org/apache/commons/build/BuildAttestationMojo.java     | 14 --------------
 .../org/apache/commons/build/BuildAttestationMojoTest.java |  2 --
 2 files changed, 16 deletions(-)

diff --git a/src/main/java/org/apache/commons/build/BuildAttestationMojo.java b/src/main/java/org/apache/commons/build/BuildAttestationMojo.java
index d021d2d..02cd3c3 100644
--- a/src/main/java/org/apache/commons/build/BuildAttestationMojo.java
+++ b/src/main/java/org/apache/commons/build/BuildAttestationMojo.java
@@ -84,12 +84,6 @@ public class BuildAttestationMojo extends AbstractMojo {
     @Parameter(defaultValue = "${project.scm.connection}", readonly = true)
     private String scmConnectionUrl;
 
-    @Parameter(defaultValue = "${project.scm.developerConnection}", readonly = true)
-    private String scmDeveloperConnectionUrl;
-
-    @Parameter(defaultValue = "${project.scm.tag}", readonly = true)
-    private String scmTag;
-
     @Parameter(defaultValue = "${maven.home}", readonly = true)
     private File mavenHome;
 
@@ -156,14 +150,6 @@ public class BuildAttestationMojo extends AbstractMojo {
         this.scmConnectionUrl = scmConnectionUrl;
     }
 
-    void setScmDeveloperConnectionUrl(String scmDeveloperConnectionUrl) {
-        this.scmDeveloperConnectionUrl = scmDeveloperConnectionUrl;
-    }
-
-    void setScmTag(String scmTag) {
-        this.scmTag = scmTag;
-    }
-
     void setMavenHome(File mavenHome) {
         this.mavenHome = mavenHome;
     }
diff --git a/src/test/java/org/apache/commons/build/BuildAttestationMojoTest.java b/src/test/java/org/apache/commons/build/BuildAttestationMojoTest.java
index 46ed892..a119b95 100644
--- a/src/test/java/org/apache/commons/build/BuildAttestationMojoTest.java
+++ b/src/test/java/org/apache/commons/build/BuildAttestationMojoTest.java
@@ -102,8 +102,6 @@ public class BuildAttestationMojoTest {
         mojo.setOutputDirectory(new File("target/attestations"));
         mojo.setScmDirectory(new File("."));
         mojo.setScmConnectionUrl("scm:git:https://github.com/apache/commons-lang.git");
-        mojo.setScmDeveloperConnectionUrl("scm:git:ssh://git@github.com/apache/commons-lang.git");
-        mojo.setScmTag("tag");
         mojo.setMavenHome(new File(System.getProperty("maven.home", ".")));
         mojo.execute();