[jira] [Commented] (FLINK-6901) Flip checkstyle configuration files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078545#comment-16078545 ] 

ASF GitHub Bot commented on FLINK-6901:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4112
  
    LGTM on a second look. Don't have any suggestion on NettyBufferPool. @uce?


> Flip checkstyle configuration files
> -----------------------------------
>
>                 Key: FLINK-6901
>                 URL: https://issues.apache.org/jira/browse/FLINK-6901
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>
> We currently have 2 checkstyle files, {{checkstyle.xml}} as the basic version, and {{strict-checkstyle.xml}} as a heavily expanded version that is applied to most existing modules (see FLINK-6698).
> [~greghogan] suggested to flip the checkstyle while reviewing this PR https://github.com/apache/flink/pull/4086, given that the strict checkstyle is supposed to subsume the existing checkstyle in the long-term.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)