You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2014/12/01 22:49:12 UTC
[jira] [Resolved] (HBASE-12566) HRegion should have an
InterfaceAudience of LimitedPrivate(PHOENIX)
[ https://issues.apache.org/jira/browse/HBASE-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Purtell resolved HBASE-12566.
------------------------------------
Resolution: Not a Problem
Fix Version/s: (was: 0.99.2)
(was: 0.98.9)
(was: 2.0.0)
Resolving as Not a Problem by consensus.
> HRegion should have an InterfaceAudience of LimitedPrivate(PHOENIX)
> -------------------------------------------------------------------
>
> Key: HBASE-12566
> URL: https://issues.apache.org/jira/browse/HBASE-12566
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Labels: Phoenix
>
> I've discovered after HBASE-12550 that Phoenix has a class that was broken by a change to a package scoped method in HRegion:
> {code}
> diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/reg
> index 39a9fdc..3377e6b 100644
> --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> @@ -4628,11 +4628,12 @@ public class HRegion implements HeapSize { // , Writable{
> /**
> * Create a daughter region from given a temp directory with the region data.
> * @param hri Spec. for daughter region to open.
> + * @param expectedReferenceFileCount
> * @throws IOException
> */
> - HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException {
> + HRegion createDaughterRegionFromSplits(final HRegionInfo hri, int expectedReferenceFileCount) throws IOException {
> // Move the files from the temporary .splits to the final /table/region directory
> - fs.commitDaughterRegion(hri);
> + fs.commitDaughterRegion(hri, expectedReferenceFileCount);
> {code}
> We should change the HRegion InterfaceAudience to LimitedPrivate(COPROC, PHOENIX).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)