You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/11 18:36:41 UTC
[jira] [Commented] (BEAM-1935) DirectRunner Cancel should never
throw a RejectedExecutionException
[ https://issues.apache.org/jira/browse/BEAM-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964790#comment-15964790 ]
ASF GitHub Bot commented on BEAM-1935:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2493
[BEAM-1935] Improve Work Rejection handling
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
The timing between checking for a shutdown state and submitting work is
racy. Re-check to see if a work rejection is acceptable because the
underlying executor is shut down before throwing a
RejectedExecutionException.
Renames to internal implementation classes of TransformExecutorServices.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam cancel_rejected_execution
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2493
----
commit 528830185a9735bb49a64074480760a661e39408
Author: Thomas Groh <tg...@google.com>
Date: 2017-04-11T18:33:53Z
Improve Work Rejection handling
The timing between checking for a shutdown state and submitting work is
racy. Re-check to see if a work rejection is acceptable because the
underlying executor is shut down before throwing a
RejectedExecutionException.
----
> DirectRunner Cancel should never throw a RejectedExecutionException
> -------------------------------------------------------------------
>
> Key: BEAM-1935
> URL: https://issues.apache.org/jira/browse/BEAM-1935
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> cancelShouldStopPipeline(org.apache.beam.runners.direct.DirectRunnerTest) Time elapsed: 0.025 sec <<< ERROR!
> java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@391aff79 rejected from java.util.concurrent.ThreadPoolExecutor@3d257c82[Shutting down, pool size = 1, active threads = 1, queue
> d tasks = 0, completed tasks = 0]
> at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047)
> at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823)
> at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369)
> at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112)
> at org.apache.beam.runners.direct.TransformExecutorServices$ParallelEvaluationState.schedule(TransformExecutorServices.java:69)
> at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor.evaluateBundle(ExecutorServiceParallelExecutor.java:245)
> at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor.scheduleConsumption(ExecutorServiceParallelExecutor.java:208)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)