You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/06 20:49:51 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3569: ARTEMIS-3285 potential duplicate messages with LVQ + non-destructive

clebertsuconic commented on a change in pull request #3569:
URL: https://github.com/apache/activemq-artemis/pull/3569#discussion_r627755378



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSNonDestructiveTest.java
##########
@@ -588,4 +594,82 @@ private void sendLVQTombstone(ConnectionSupplier producerConnectionSupplier, Str
          producer.send(message1, javax.jms.Message.DEFAULT_DELIVERY_MODE, javax.jms.Message.DEFAULT_PRIORITY, tombstoneTimeToLive);
       }
    }
+
+   @Test
+   public void testMultipleLastValuesCore() throws Exception {
+      testMultipleLastValues(CoreConnection);

Review comment:
       Can you instead use CFUtil.createConnectionFactory("AMQP", "tcp://localhost:61616")
   
   or 
   
   CFUtil.createConnectionFactory("CORE", "tcp://localhost:61616")
   
   
   We should probably remove the Connection supplier. It's a bit simpler to read.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org