[GitHub] [kylin] weibin0516 opened a new pull request #729: [KYLIN-4068] append limit and offset to sql reliably

[GitBox <gi...@apache.org>]

weibin0516 opened a new pull request #729: [KYLIN-4068] append limit and offset to sql reliably
URL: https://github.com/apache/kylin/pull/729
 
 
   ## What changes were proposed in this pull request?
   Currently, there is a bug in sql conversion, as follow:
   
   ```sql
   SELECT E_Name FROM Employees_China
   UNION
   SELECT E_Name FROM Employees_USA
   ```
   
   will convert to
   
   ```sql
   SELECT E_Name FROM Employees_China
   UNION
   SELECT E_Name FROM Employees_USA
   LIMIT 50000
   ```
   
   This limit is not working on the result of union, but on SELECT E_Name FROM Employees_USA.
   We should use a more secure way to achieve the limit effect.
   
   This pr fixed the bug, making sure to append limit or offset after sql does not change sql semantics
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services