You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by sh...@apache.org on 2009/03/20 19:43:41 UTC
svn commit: r756703 -
/lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java
Author: shalin
Date: Fri Mar 20 18:43:39 2009
New Revision: 756703
URL: http://svn.apache.org/viewvc?rev=756703&view=rev
Log:
SOLR-973 followup - Create OutputStreamWriter with utf-8 encoding
Modified:
lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java
Modified: lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java?rev=756703&r1=756702&r2=756703&view=diff
==============================================================================
--- lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java (original)
+++ lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java Fri Mar 20 18:43:39 2009
@@ -66,7 +66,7 @@
public void write(SolrRequest request, OutputStream os) throws IOException {
if (request instanceof UpdateRequest) {
UpdateRequest updateRequest = (UpdateRequest) request;
- OutputStreamWriter writer = new OutputStreamWriter(os);
+ OutputStreamWriter writer = new OutputStreamWriter(os, "UTF-8");
updateRequest.writeXML(writer);
writer.flush();
}
Re: svn commit: r756703 - /lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java
Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
On Sat, Mar 21, 2009 at 8:18 AM, Chris Hostetter
<ho...@fucit.org>wrote:
>
> : + OutputStreamWriter writer = new OutputStreamWriter(os, "UTF-8");
>
> Minor nit, but using something like
>
> public static final Charset UTF_8 = Charset.forName("UTF-8");
> ...
> OutputStreamWriter writer = new OutputStreamWriter(os, UTF_8);
>
> ...would be a little cleaner here. no reason to pay the charset lookup
> cost everytime for a hardcoded constant.
>
Good point. I'll fix.
--
Regards,
Shalin Shekhar Mangar.
Re: svn commit: r756703 -
/lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java
Posted by Chris Hostetter <ho...@fucit.org>.
: + OutputStreamWriter writer = new OutputStreamWriter(os, "UTF-8");
Minor nit, but using something like
public static final Charset UTF_8 = Charset.forName("UTF-8");
...
OutputStreamWriter writer = new OutputStreamWriter(os, UTF_8);
...would be a little cleaner here. no reason to pay the charset lookup
cost everytime for a hardcoded constant.
-Hoss