You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/23 15:57:07 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #5770: fix bug for ClassCastException when execute range query in numeric type

strongduanmu opened a new pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770


   Fixes #5544 .
   
   Changes proposed in this pull request:
   - fix ClassCastException when execute range query with different numeric type like `t.clusterId > 3 and t.clusterId < 3147483647 and t.clusterId in (1, 2, 4)`
   - fix ClassCastException when execute range query with different numeric type like `t.clusterId between 3 and 3147483647`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633601847






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5770: fix bug for ClassCastException when execute range query in numeric type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633086829


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=h1) Report
   > Merging [#5770](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0fbf7d7c4ccca5c854aa8ba43b8f17c5c9d2c357&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `63.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5770/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5770      +/-   ##
   ============================================
   + Coverage     53.04%   53.07%   +0.03%     
     Complexity      437      437              
   ============================================
     Files          1178     1179       +1     
     Lines         20721    20776      +55     
     Branches       3736     3754      +18     
   ============================================
   + Hits          10991    11027      +36     
   - Misses         9059     9068       +9     
   - Partials        671      681      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ion/engine/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1doZXJlQ2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `48.57% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/sql/parser/sql/util/SafeRangeOperationUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdXRpbC9TYWZlUmFuZ2VPcGVyYXRpb25VdGlscy5qYXZh) | `65.45% <65.45%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/impl/ConditionValueBetweenOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVCZXR3ZWVuT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `69.23% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=footer). Last update [0fbf7d7...4a1eaac](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu edited a comment on pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
strongduanmu edited a comment on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633601847


   Hi, @tristaZero , the following is the error that appears when I execute the `mvn clean install -Prelease` command: 
   ```
   [INFO] Running org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest
   [ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0.23 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest
   [ERROR] assertQueryWithEmptyString(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest)  Time elapsed: 0.06 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertExecuteUpdateGetResultSet(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest)  Time elapsed: 0.008 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetGeneratedKeys(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest)  Time elapsed: 0.006 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertExecuteGetResultSet(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest)  Time elapsed: 0.007 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertQueryWithNull(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSphereStatementTest)  Time elapsed: 0.006 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest
   [ERROR] Tests run: 14, Failures: 0, Errors: 12, Skipped: 2, Time elapsed: 0.2 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest
   [ERROR] assertClearBatch(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.009 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertQueryWithEmptyString(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.014 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAddBatch(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.006 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertInitPreparedStatementExecutorWithReplayMethod(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.009 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAddBatchWithGenerateKeyColumn(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.006 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAddBatchWithoutGenerateKeyColumn(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.008 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertExecuteUpdateGetResultSet(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.008 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertExecuteGetResultSet(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.007 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertQueryWithNull(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.007 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetParameterMetaData(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.007 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertUpdateBatch(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.008 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAddOnDuplicateKey(org.apache.shardingsphere.driver.jdbc.core.statement.ShardingSpherePreparedStatementTest)  Time elapsed: 0.008 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.core.statement.MasterSlavePreparedStatementTest
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.085 s - in org.apache.shardingsphere.driver.jdbc.core.statement.MasterSlavePreparedStatementTest
   [INFO] Running org.apache.shardingsphere.driver.jdbc.core.statement.ShadowStatementTest
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.188 s - in org.apache.shardingsphere.driver.jdbc.core.statement.ShadowStatementTest
   [INFO] Running org.apache.shardingsphere.driver.jdbc.core.statement.EncryptStatementTest
   [INFO] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.272 s - in org.apache.shardingsphere.driver.jdbc.core.statement.EncryptStatementTest
   [INFO] Running org.apache.shardingsphere.driver.jdbc.core.statement.ShadowPreparedStatementTest
   [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.129 s - in org.apache.shardingsphere.driver.jdbc.core.statement.ShadowPreparedStatementTest
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationDataSourceTest
   [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.063 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationDataSourceTest
   [ERROR] assertGetLoginTimeout(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationDataSourceTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetLoginTimeout(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationDataSourceTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest
   [ERROR] Tests run: 10, Failures: 0, Errors: 10, Skipped: 0, Time elapsed: 0.1 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest
   [ERROR] assertSetNString(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetMetaData(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetRef(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetNCharacterStreamWithLength(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetNCharacterStream(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetArray(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetNClob(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetRowId(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.006 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetNClobForReader(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetNClobForReaderAndLength(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationPreparedStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest
   [ERROR] Tests run: 8, Failures: 0, Errors: 8, Skipped: 0, Time elapsed: 0.089 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest
   [ERROR] assertSetFetchDirection(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertClearBatch(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAddBatch(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsCloseOnCompletion(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCloseOnCompletion(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetFetchDirection(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertExecuteBatch(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetCursorName(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationStatementTest)  Time elapsed: 0.007 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnSupportedDatabaseMetaDataResultSetTest
   [INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.apache.shardingsphere.driver.jdbc.unsupported.UnSupportedDatabaseMetaDataResultSetTest
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest
   [ERROR] Tests run: 8, Failures: 0, Errors: 8, Skipped: 0, Time elapsed: 0.089 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest
   [ERROR] assertGetParameterClassName(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsSigned(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetPrecision(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsNullable(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetParameterTypeName(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetScale(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetParameterMode(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetParameterType(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationParameterMetaTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest
   [ERROR] Tests run: 28, Failures: 0, Errors: 28, Skipped: 0, Time elapsed: 0.162 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest
   [ERROR] assertCreateSQLXML(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCreateStruct(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetCatalog(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetClientInfoWithName(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetSavepoint(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.006 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertReleaseSavepoint(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetClientInfoWithProperties(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetTypeMap(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertRollback(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertNativeSQL(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsValid(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCreateBlob(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCreateClob(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAbort(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetCatalog(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertPrepareCall(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetNetworkTimeout(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetClientInfo(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetTypeMap(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertPrepareCallWithResultSetTypeAndResultSetConcurrencyAndResultSetHoldability(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetSchema(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetSchema(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetSavepointWithName(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCreateNClob(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCreateArrayOf(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertSetClientInfo(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetNetworkTimeout(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertPrepareCallWithResultSetTypeAndResultSetConcurrency(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationConnectionTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedGeneratedKeysResultSetTest
   [INFO] Tests run: 38, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 s - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedGeneratedKeysResultSetTest
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest
   [ERROR] Tests run: 40, Failures: 0, Errors: 40, Skipped: 0, Time elapsed: 0.178 s <<< FAILURE! - in org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest
   [ERROR] assertPrevious(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertRefreshRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertUpdateRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertObjectForColumnLabelWithType(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertRowInserted(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsLast(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertRelative(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertRowDeleted(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetRowIdForColumnIndex(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetRowIdForColumnLabel(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetCursorName(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsAfterLast(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertMoveToInsertRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetRefForColumnIndex(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetRefForColumnLabel(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsFirst(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertInsertRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertDeleteRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertFirst(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetNClobForColumnIndex(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetNClobForColumnLabel(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertBeforeFirst(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertMoveToCurrentRow(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] getNStringForColumnIndex(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] getNStringForColumnLabel(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] getNCharacterStreamForColumnIndex(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] getNCharacterStreamForColumnLabel(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertObjectForColumnLabelWithMap(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertCancelRowUpdates(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAbsolute(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetHoldability(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertAfterLast(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.003 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertIsBeforeFirst(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.005 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertObjectForColumnIndexWithType(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertRowUpdated(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetArrayForColumnIndex(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertGetArrayForColumnLabel(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertLast(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [ERROR] assertObjectForColumnIndexWithMap(org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedOperationResultSetTest)  Time elapsed: 0.004 s  <<< ERROR!
   java.lang.ClassCastException: java.math.BigInteger cannot be cast to java.lang.Integer
   
   [INFO] Running org.apache.shardingsphere.driver.jdbc.unsupported.UnsupportedUpdateOperationResultSetTest
   ```
   The above error message is that BigInteger cannot be converted to Long or Integer type, because the Long or Integer type supports mod operation(%), however BigInteger doesn't support it. The following is a typical error scenario, `shardingValue.getValue()` will always return BigInteger type value, and resulting in an error in mod operation:
   ```java
   @Override
   public String doSharding(final Collection<String> availableTargetNames, final PreciseShardingValue<Integer> shardingValue) {
       for (String each : availableTargetNames) {
           if (each.endsWith(String.valueOf(shardingValue.getValue() % 2))) {
               return each;
           }
       }
       return null;
   }
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #5770: fix bug for ClassCastException when execute range query in numeric type

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#discussion_r429594269



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SafeRangeOperationUtils.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.util;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Range;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.SneakyThrows;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/**
+ * Safe range operation utility class.
+ */
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SafeRangeOperationUtils {
+
+    /**
+     * Execute intersection method by safe mode.
+     *
+     * @param range          range
+     * @param connectedRange connected range

Review comment:
       > What's mean of variable name `connectedRange`?
   
   In order to consistent with the intersection method in Guava Range. The following is the definition of the intersection method:
   
   ```java
   /**
   * Returns the maximal range {@linkplain #encloses enclosed} by both this range and {@code
   * connectedRange}, if such a range exists.
   *
   * <p>For example, the intersection of {@code [1..5]} and {@code (3..7)} is {@code (3..5]}. The
   * resulting range may be empty; for example, {@code [1..5)} intersected with {@code [5..7)}
   * yields the empty range {@code [5..5)}.
   *
   * <p>The intersection exists if and only if the two ranges are {@linkplain #isConnected
   * connected}.
   *
   * <p>The intersection operation is commutative, associative and idempotent, and its identity
   * element is {@link Range#all}).
   *
   * @throws IllegalArgumentException if {@code isConnected(connectedRange)} is {@code false}
   */
   public Range<C> intersection(Range<C> connectedRange) {
       int lowerCmp = lowerBound.compareTo(connectedRange.lowerBound);
       int upperCmp = upperBound.compareTo(connectedRange.upperBound);
       if (lowerCmp >= 0 && upperCmp <= 0) {
           return this;
       } else if (lowerCmp <= 0 && upperCmp >= 0) {
           return connectedRange;
       } else {
           Cut<C> newLower = (lowerCmp >= 0) ? lowerBound : connectedRange.lowerBound;
           Cut<C> newUpper = (upperCmp <= 0) ? upperBound : connectedRange.upperBound;
           return create(newLower, newUpper);
       }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #5770: fix bug for ClassCastException when execute range query in numeric type

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#discussion_r429594349



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SafeRangeOperationUtils.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.util;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Range;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.SneakyThrows;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/**
+ * Safe range operation utility class.
+ */
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SafeRangeOperationUtils {
+
+    /**
+     * Execute intersection method by safe mode.
+     *
+     * @param range          range
+     * @param connectedRange connected range
+     * @return the intersection result of two ranges

Review comment:
       > Please do not format java doc, just keep one space with `@aparam` and `@return`
   
   Thank you! I got it, and I will modify it. 😀
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633086829


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=h1) Report
   > Merging [#5770](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0fbf7d7c4ccca5c854aa8ba43b8f17c5c9d2c357&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `63.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5770/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5770      +/-   ##
   ============================================
   - Coverage     53.04%   52.87%   -0.17%     
   + Complexity      437      433       -4     
   ============================================
     Files          1178     1180       +2     
     Lines         20721    20808      +87     
     Branches       3736     3755      +19     
   ============================================
   + Hits          10991    11002      +11     
   - Misses         9059     9131      +72     
   - Partials        671      675       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ion/engine/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1doZXJlQ2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `48.57% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/sql/parser/sql/util/SafeRangeOperationUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdXRpbC9TYWZlUmFuZ2VPcGVyYXRpb25VdGlscy5qYXZh) | `65.45% <65.45%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/impl/ConditionValueBetweenOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVCZXR3ZWVuT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `69.23% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ication/jdbc/wrapper/StatementExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvd3JhcHBlci9TdGF0ZW1lbnRFeGVjdXRvcldyYXBwZXIuamF2YQ==) | `6.66% <0.00%> (-14.77%)` | `0.00% <0.00%> (ø%)` | |
   | [...jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvd3JhcHBlci9QcmVwYXJlZFN0YXRlbWVudEV4ZWN1dG9yV3JhcHBlci5qYXZh) | `7.14% <0.00%> (-14.29%)` | `0.00% <0.00%> (ø%)` | |
   | [...roxy/backend/text/admin/UnicastBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2FkbWluL1VuaWNhc3RCYWNrZW5kSGFuZGxlci5qYXZh) | `66.66% <0.00%> (-8.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/proxy/backend/schema/ShardingSphereSchemas.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWFzLmphdmE=) | `23.07% <0.00%> (-3.85%)` | `0.00% <0.00%> (ø%)` | |
   | [.../communication/jdbc/execute/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `19.35% <0.00%> (-2.87%)` | `0.00% <0.00%> (ø%)` | |
   | [...ore/statement/ShardingSpherePreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `77.98% <0.00%> (-1.00%)` | `1.00% <0.00%> (ø%)` | |
   | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `66.89% <0.00%> (-0.47%)` | `1.00% <0.00%> (ø%)` | |
   | ... and [72 more](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=footer). Last update [0fbf7d7...a1b134a](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #5770: fix bug for ClassCastException when execute range query in numeric type

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#discussion_r429592966



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SafeRangeOperationUtils.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.util;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Range;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.SneakyThrows;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/**
+ * Safe range operation utility class.
+ */
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SafeRangeOperationUtils {
+
+    /**
+     * Execute intersection method by safe mode.
+     *
+     * @param range          range
+     * @param connectedRange connected range
+     * @return the intersection result of two ranges

Review comment:
       Please do not format java doc, just keep one space with `@aparam` and `@return`

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/util/SafeRangeOperationUtils.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.util;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Range;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.SneakyThrows;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+/**
+ * Safe range operation utility class.
+ */
+@AllArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SafeRangeOperationUtils {
+
+    /**
+     * Execute intersection method by safe mode.
+     *
+     * @param range          range
+     * @param connectedRange connected range

Review comment:
       What's mean of variable name `connectedRange`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#discussion_r430138138



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/test/java/org/apache/shardingsphere/sharding/route/engine/condition/generator/impl/ConditionValueBetweenOperatorGeneratorTest.java
##########
@@ -36,11 +37,11 @@
 import static org.junit.Assert.assertTrue;
 
 public final class ConditionValueBetweenOperatorGeneratorTest {
-    
+

Review comment:
       A newline is supposed to start with 4 blank spaces. Just a little issue of check style. Apart from that, I approved. Thanks for the clean coding!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633365360


   Hi @strongduanmu 
   
   I reviewed your PR, whose core logic is spotless, and tests are enough. I believe you worked hard for it. But I also wonder what you said here.
   
   > BTW, I also tried the first solution, and all returned BigInteger types, which would cause many existing unit tests to report errors, so I still prefer the second method.
   
   Could you post the exception here? Therefore we can judge whether the fist solution is practical or not. 
   
   Currently, your PR provides a great implementation of the second one. But actually, the reason why the first solution draws my attention is that it looks so simple and free from any other utils (Not sure).  :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #5770: fix bug for ClassCastException when execute range query with different numeric type

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633886097


   Hi @strongduanmu 
   Sorry for the late response. Some of the meetings blocked me.
   Anyway, I appreciated your initiative to solve the issue from the community! 
   Looking forward to your standout in the community. :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5770: fix bug for ClassCastException when execute range query in numeric type

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5770:
URL: https://github.com/apache/shardingsphere/pull/5770#issuecomment-633086829


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=h1) Report
   > Merging [#5770](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0fbf7d7c4ccca5c854aa8ba43b8f17c5c9d2c357&el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `63.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5770/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5770      +/-   ##
   ============================================
   + Coverage     53.04%   53.07%   +0.03%     
     Complexity      437      437              
   ============================================
     Files          1178     1179       +1     
     Lines         20721    20776      +55     
     Branches       3736     3754      +18     
   ============================================
   + Hits          10991    11027      +36     
   - Misses         9059     9068       +9     
   - Partials        671      681      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ion/engine/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1doZXJlQ2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `48.57% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/sql/parser/sql/util/SafeRangeOperationUtils.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdXRpbC9TYWZlUmFuZ2VPcGVyYXRpb25VdGlscy5qYXZh) | `65.45% <65.45%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/impl/ConditionValueBetweenOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5770/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVCZXR3ZWVuT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `69.23% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=footer). Last update [0fbf7d7...b70a778](https://codecov.io/gh/apache/shardingsphere/pull/5770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org