[GitHub] [cassandra] jasonstack commented on a change in pull request #630: Fix RepairJobsTest.testNoTreesRetainedAfterDifference by waiting for …

[GitBox <gi...@apache.org>]

jasonstack commented on a change in pull request #630:
URL: https://github.com/apache/cassandra/pull/630#discussion_r442317941



##########
File path: test/unit/org/apache/cassandra/repair/RepairJobTest.java
##########
@@ -91,14 +95,16 @@
     private static InetAddressAndPort addr3;
     private static InetAddressAndPort addr4;
     private static InetAddressAndPort addr5;
-    private RepairSession session;
+    private MeasureableRepairSession session;
     private RepairJob job;
     private RepairJobDesc sessionJobDesc;
 
     // So that threads actually get recycled and we can have accurate memory accounting while testing
     // memory retention from CASSANDRA-14096
     private static class MeasureableRepairSession extends RepairSession
     {
+        List<Callable<?>> onSyncComplete = new ArrayList<>();

Review comment:
       +1 changed to `syncCompleteCallbacks`

##########
File path: test/unit/org/apache/cassandra/repair/RepairJobTest.java
##########
@@ -152,6 +182,7 @@ public void setup()
     @After
     public void reset()
     {
+        session.onSyncComplete.clear();

Review comment:
       removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org