You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/04 09:18:15 UTC
[GitHub] [flink] JingsongLi opened a new pull request #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
JingsongLi opened a new pull request #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304
## What is the purpose of the change
Version in Yaml/HiveCatalog needs to be consistent with the dependencies version. There are three places: version in metastore, version in dependencies, version in Yaml/HiveCatalog, users are easy to make mistakes.
## Brief change log
- Add constructor without hive version to HiveCatalog and HiveModule
- Remove hive version in document
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595108866
Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi merged pull request #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi edited a comment on issue #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi edited a comment on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595019043
> what's the "hive version" of Hive in CDH or HDP?
Is there any users use CDH or HDP client dependencies? The users that use CDH I know they just use open-source corresponding hive client dependencies.
Like Spark&Presto, they just use built-in hive client dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-594429089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5904",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151700198",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d483d0732cb0f52565611001fd741cd8b94a05ff UNKNOWN
* b2e46756e98af136a45fffd46749a5c1c61dc7bd Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151700198) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5904)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595068612
@bowenli86 @JingsongLi For HDP and CDH users, I think they probably should use the HDP and CDH version Hive jars. For example, HDP Hive-1.2.1 has cherry picked lots of patches from newer version and therefore is different from Apache Hive-1.2.1. So using the HDP version usually means users can have the extra bug fixes than the Apache version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-594429089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d483d0732cb0f52565611001fd741cd8b94a05ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595108572
> @bowenli86 @JingsongLi For HDP and CDH users, I think they probably should use the HDP and CDH version Hive jars. For example, HDP Hive-1.2.1 has cherry picked lots of patches from newer version and therefore is different from Apache Hive-1.2.1. So using the HDP version usually means users can have the extra bug fixes than the Apache version.
OK, I think this cases should be document, because it is not so easy to do, so I created JIRA: https://issues.apache.org/jira/browse/FLINK-16434 for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-594429089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d483d0732cb0f52565611001fd741cd8b94a05ff UNKNOWN
* b2e46756e98af136a45fffd46749a5c1c61dc7bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-594429089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5904",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151700198",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d483d0732cb0f52565611001fd741cd8b94a05ff UNKNOWN
* b2e46756e98af136a45fffd46749a5c1c61dc7bd Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151700198) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5904)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi edited a comment on issue #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi edited a comment on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595108572
> @bowenli86 @JingsongLi For HDP and CDH users, I think they probably should use the HDP and CDH version Hive jars. For example, HDP Hive-1.2.1 has cherry picked lots of patches from newer version and therefore is different from Apache Hive-1.2.1. So using the HDP version usually means users can have the extra bug fixes than the Apache version.
OK, I think this cases should be document, because it is not so easy to do, so I created JIRA: https://issues.apache.org/jira/browse/FLINK-16434 for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595017818
what's the "hive version" of Hive in CDH or HDP?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-594410989
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d483d0732cb0f52565611001fd741cd8b94a05ff (Wed Mar 04 09:22:11 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595001501
> LGTM, except that we need documentation stating that
>
> 1. hive versions will be automatically inferred at runtime
> 2. hive versions in these configs are optional, users still can specify explicitly if they want to
Hi @bowenli86 , I prefer not provide this message, I can not find the case users need to configure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595019043
> what's the "hive version" of Hive in CDH or HDP?
Is there any users use CDH or HDP client? The users that use CDH I know they just use open-source corresponding hive client dependencies.
Like Spark&Presto, they just use built-in hive client dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-594429089
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d483d0732cb0f52565611001fd741cd8b94a05ff",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5904",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
}, {
"hash" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151700198",
"triggerID" : "b2e46756e98af136a45fffd46749a5c1c61dc7bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d483d0732cb0f52565611001fd741cd8b94a05ff UNKNOWN
* b2e46756e98af136a45fffd46749a5c1c61dc7bd Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151700198) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5904)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #11304: [FLINK-16418][hive]
Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#issuecomment-595052986
@lirui-apache can you confirm?
otherwise, I'm +1 for this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #11304:
[FLINK-16418][hive] Hide hive version to avoid user confuse
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #11304: [FLINK-16418][hive] Hide hive version to avoid user confuse
URL: https://github.com/apache/flink/pull/11304#discussion_r387552584
##########
File path: flink-table/flink-sql-client/src/test/resources/test-sql-client-catalogs.yaml
##########
@@ -155,7 +155,6 @@ catalogs:
- name: hivecatalog
type: hive
test: test
- hive-version: 2.3.4
Review comment:
I don't think this one should be removed. It's there to verify the version provided by user takes precedence over the version detected in classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services