[jira] [Commented] (MESOS-1105) TODO(benh): choose a better scheme to set mem in slave/containerizer.cpp

["Ashutosh Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937191#comment-13937191 ] 

Ashutosh Jain commented on MESOS-1105:
--------------------------------------

I have chosen 50% of mem as criteria . If it is fine.

      // Limit set to 50% of memory and doing a check so that mem is set
      // to 50% of mem and not more than 1 GB 
      Bytes limit = mem.megabytes()/2;
      if (mem > Gigabytes(2)) {
        mem = mem - Gigabytes(1);
      } else {
        mem = mem - limit;
      }

> TODO(benh): choose a better scheme to set mem in slave/containerizer.cpp
> ------------------------------------------------------------------------
>
>                 Key: MESOS-1105
>                 URL: https://issues.apache.org/jira/browse/MESOS-1105
>             Project: Mesos
>          Issue Type: Improvement
>    Affects Versions: 0.19.0
>            Reporter: Ashutosh Jain
>            Assignee: Ashutosh Jain
>            Priority: Minor
>             Fix For: 0.19.0
>
>
> Earlier, if memory was less than 1 GB than whole memory was used else 1 GB was reserved for the system. A better scheme would to set a percentage of memory.  
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/containerizer.cpp?source=c#L106



--
This message was sent by Atlassian JIRA
(v6.2#6252)