[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3662: [KYUUBI #2887] Add a POLLING balance policy for spark engine pool

[GitBox <gi...@apache.org>]

pan3793 commented on PR #3662:
URL: https://github.com/apache/incubator-kyuubi/pull/3662#issuecomment-1284421236

   A high-level comment, I checked your closed PR using `o.a.c...DistributedAtomicInteger`, I think it's a good idea, to make it decouple w/ zookeeper, we can add a method in 
   ```
   traits DiscoveryClient {
     ...
     def getAndInc(path: String): Int
   }
   ```
   For Zookeeper, `DistributedAtomicInteger` can be used to implement, and for ETCD, explicitly lock and get then set may be required. We also got reported that some guys want a JDBC-based DiscoveryClient implementation, and implementing the method using SQL is not much complex.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org