[GitHub] [lucene-solr] andywebb1975 commented on pull request #2643: SOLR-9359 Make Config API work for warming queries

[GitBox <gi...@apache.org>]

andywebb1975 commented on pull request #2643:
URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1080930412


   I've given this some more attention:
   
   * found the `getArgs().getAll()` method which means it now works with a flat list like in my last comment above
   * moved most of the change into a `queries2list` method
   * various updates inside that method
   
   I'm running this on our prototype stack to battle-test it with our content/configs. Obviously there'd be more to do before this could be merged, like tidying up the code more and adding tests - and also I'm aware 8.11 is end-of-line so this could become a 9.x thing instead. (We're running a custom build so wouldn't need it to be merged into 8.11.)
   
   I'm honestly not sure where to begin with creating tests for this using config provided via the Config API! Is there anything similar I could take a lead from?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org