You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/02/19 02:21:08 UTC
[GitHub] [tinkerpop] spmallette opened a new pull request #1572: TINKERPOP-2467 Follow python naming conventions for Gremlin syntax
spmallette opened a new pull request #1572:
URL: https://github.com/apache/tinkerpop/pull/1572
https://issues.apache.org/jira/browse/TINKERPOP-2467
Retained the old camel case and just deprecated it. Added snake case along side it. PythonTranslator still generates the old style for now which is helpful because it continues to test the deprecation working all the way through to the new functions.
Don't think there is a huge rush to drop the deprecated steps. We can move the translator for the next major release and that will set us up to remove the deprecated steps at our leisure in the major following that (or later if desired). The main point of this PR is to at least introduce the consistently named steps so that they can begin to see usage.
Builds with `mvn clean install -pl gremlin-python -DincludeeNeo4j`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1572: TINKERPOP-2467 Follow python naming conventions for Gremlin syntax
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1572:
URL: https://github.com/apache/tinkerpop/pull/1572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] divijvaidya commented on pull request #1572: TINKERPOP-2467 Follow python naming conventions for Gremlin syntax
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on pull request #1572:
URL: https://github.com/apache/tinkerpop/pull/1572#issuecomment-1047022892
Every time we change syntax significantly, we add additional overhead for users to consume the new version of TinkerPop. What is the motivation of merging this to master (tracking 3.6.x)? I would probably see this as a candidate for 4.0.
Also, please document this in the developers guide "how to add a new step" section so that we can maintain consistency for steps in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1572: TINKERPOP-2467 Follow python naming conventions for Gremlin syntax
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1572:
URL: https://github.com/apache/tinkerpop/pull/1572#issuecomment-1047031851
I don't see additional overhead to users if the old naming is still present. The deprecation can stay indefinitely if we desire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] mikepersonick commented on pull request #1572: TINKERPOP-2467 Follow python naming conventions for Gremlin syntax
Posted by GitBox <gi...@apache.org>.
mikepersonick commented on pull request #1572:
URL: https://github.com/apache/tinkerpop/pull/1572#issuecomment-1046022632
lgtm +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] divijvaidya commented on pull request #1572: TINKERPOP-2467 Follow python naming conventions for Gremlin syntax
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on pull request #1572:
URL: https://github.com/apache/tinkerpop/pull/1572#issuecomment-1047894426
> I don't see additional overhead to users if the old naming is still present. The deprecation can stay indefinitely if we desire.
My bad. I read this PR as changing the syntax and not just deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org