[GitHub] [hudi] CTTY commented on a diff in pull request #5734: [HUDI-4177] Fix hudi-cli rollback with rollbackUsingMarkers method call

[GitBox <gi...@apache.org>]

CTTY commented on code in PR #5734:
URL: https://github.com/apache/hudi/pull/5734#discussion_r887444565


##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java:
##########
@@ -451,7 +451,7 @@ private static int doBootstrap(JavaSparkContext jsc, String tableName, String ta
   }
 
   private static int rollback(JavaSparkContext jsc, String instantTime, String basePath, Boolean rollbackUsingMarkers) throws Exception {
-    SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers);
+    SparkRDDWriteClient client = createHoodieClient(jsc, basePath, rollbackUsingMarkers, false);

Review Comment:
   This call here is supposed to call method at L529 [here](https://github.com/apache/hudi/blob/cd314b74eabaf187ce073ec938a6a38e502288f1/hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java#L529), but currently it's calling method at L534 [here](https://github.com/apache/hudi/blob/cd314b74eabaf187ce073ec938a6a38e502288f1/hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java#L534), and it's passing `rollbackUsingMarkers` as `lazyCleanPolicy`, which would cause issues when `rollbackUsingMarkers` is passed in hudi-cli



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org