You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/23 02:07:49 UTC
[GitHub] [incubator-pinot] mqliang opened a new pull request #6711: Set thread cpu time in setExecutionStatistics()
mqliang opened a new pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711
## Description
This PR remove a TODO: put thread cpu time setting logic in `setExecutionStatistics()`
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#issuecomment-804553226
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=h1) Report
> Merging [#6711](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=desc) (24dd71f) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) (1beaab5) will **decrease** coverage by `22.99%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6711 +/- ##
===========================================
- Coverage 66.44% 43.45% -23.00%
===========================================
Files 1075 1390 +315
Lines 54773 67511 +12738
Branches 8168 9783 +1615
===========================================
- Hits 36396 29338 -7058
- Misses 15700 35720 +20020
+ Partials 2677 2453 -224
```
| Flag | Coverage Δ | |
|---|---|---|
| integration | `43.45% <42.85%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...t/broker/broker/BasicAuthAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jhc2ljQXV0aEFjY2Vzc0NvbnRyb2xGYWN0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `52.83% <0.00%> (-13.84%)` | :arrow_down: |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...che/pinot/broker/queryquota/MaxHitRateTracker.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9NYXhIaXRSYXRlVHJhY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ache/pinot/broker/queryquota/QueryQuotaEntity.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9RdWVyeVF1b3RhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...ker/routing/instanceselector/InstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ceselector/StrictReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL1N0cmljdFJlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...roker/routing/segmentpruner/TimeSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL1RpbWVTZWdtZW50UHJ1bmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...roker/routing/segmentpruner/interval/Interval.java](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9zZWdtZW50cHJ1bmVyL2ludGVydmFsL0ludGVydmFsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [1418 more](https://codecov.io/gh/apache/incubator-pinot/pull/6711/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=footer). Last update [27b61fe...24dd71f](https://codecov.io/gh/apache/incubator-pinot/pull/6711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
mqliang commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r600838397
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock) _operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
Yes, we don't need to time the execution time here since this is a single thread case. For all single thread execution time, timing is conducted at `InstanceResponseBlock.getNetxBlock()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r599256521
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock) _operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
0 is not good. LIMIT 0 queries should be rare but we still process the query on one segment. So, I think we should instrument it and add the actual value here since this is a special case.
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock) _operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
0 is not desirable imo. LIMIT 0 queries should be rare but we still process the query on one segment. So, I think we should instrument it and add the actual value here since this is a special case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia merged pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
siddharthteotia merged pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r600820446
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock) _operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
It does not use the worker thread at all, so IMO it is okay to put 0 here. It won't actually process the segment, but just fetch the schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r599255480
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java
##########
@@ -70,5 +71,6 @@ public static void setExecutionStatistics(IntermediateResultsBlock resultsBlock,
resultsBlock.setNumEntriesScannedInFilter(numEntriesScannedInFilter);
resultsBlock.setNumEntriesScannedPostFilter(numEntriesScannedPostFilter);
resultsBlock.setNumTotalDocs(numTotalDocs);
+ resultsBlock.setThreadCpuTimeNs(threadCpuTimeNs);
Review comment:
Sorry, should have discussed this in previous PR. Can we please rename the method to `setExecutionThreadCpuTimeNs` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
mqliang commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r600838742
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java
##########
@@ -70,5 +71,6 @@ public static void setExecutionStatistics(IntermediateResultsBlock resultsBlock,
resultsBlock.setNumEntriesScannedInFilter(numEntriesScannedInFilter);
resultsBlock.setNumEntriesScannedPostFilter(numEntriesScannedPostFilter);
resultsBlock.setNumTotalDocs(numTotalDocs);
+ resultsBlock.setThreadCpuTimeNs(threadCpuTimeNs);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6711: Set thread cpu time in setExecutionStatistics()
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on a change in pull request #6711:
URL: https://github.com/apache/incubator-pinot/pull/6711#discussion_r600955624
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/SelectionOnlyCombineOperator.java
##########
@@ -60,7 +60,7 @@ protected IntermediateResultsBlock getNextBlock() {
// For LIMIT 0 query, only process one segment to get the data schema
if (_numRowsToKeep == 0) {
IntermediateResultsBlock resultsBlock = (IntermediateResultsBlock) _operators.get(0).nextBlock();
- CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators);
+ CombineOperatorUtils.setExecutionStatistics(resultsBlock, _operators, 0);
Review comment:
Ohh yes. Correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org