[GitHub] [nuttx-apps] patacongo commented on a diff in pull request #1683: Minor signal fix found from https://github.com/apache/nuttx/pull/8900

["patacongo (via GitHub)" <gi...@apache.org>]

patacongo commented on code in PR #1683:
URL: https://github.com/apache/nuttx-apps/pull/1683#discussion_r1149363524


##########
examples/alarm/Kconfig:
##########
@@ -33,6 +33,6 @@ config EXAMPLES_ALARM_DEVPATH
 
 config EXAMPLES_ALARM_SIGNO
 	int "Alarm signal"
-	default 1

Review Comment:
   Can this be resolved?  This PR does not address the Kconfig signal number settings any more.



##########
examples/README.md:
##########
@@ -60,7 +60,7 @@ Example Configuration:
 - `CONFIG_EXAMPLES_AJOYSTICK_DEVNAME` – Joystick device name. Default
   `/dev/adjoy0`.
 - `CONFIG_EXAMPLES_AJOYSTICK_SIGNO` – Signal used to signal the test
-  application. Default `13`.
+  application. Default `30`.

Review Comment:
   Can this be resolved? This PR does not address the Kconfig signal number settings any more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org