You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/25 13:03:14 UTC
[GitHub] [superset] kgabryje opened a new pull request, #20846: chore: Change Button background color from primary.dark1 to primary.base
kgabryje opened a new pull request, #20846:
URL: https://github.com/apache/superset/pull/20846
### SUMMARY
Change primary Button background color from `primary.dark1` to `primary.base` to make it consistent with the designs. Also, change background color from `primary.dark1` to `primary.base` of the active label in viz gallery to make it consistent with the button.
CC @kasiazjc
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="201" alt="image" src="https://user-images.githubusercontent.com/15073128/180783724-9bb34be9-1a17-4253-974b-663470cdb97d.png">
After:
<img width="196" alt="image" src="https://user-images.githubusercontent.com/15073128/180783612-89262912-c094-4761-91f9-17338cd38930.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #20846: chore: Change Button background color from primary.dark1 to primary.base
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #20846:
URL: https://github.com/apache/superset/pull/20846#issuecomment-1194064566
lgtm, thank you! 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #20846: chore: Change Button background color from primary.dark1 to primary.base
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #20846:
URL: https://github.com/apache/superset/pull/20846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org