You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/04/23 17:54:20 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5875: switch wildcard cert test case url to wikipedia.org since badssl expired
mbien opened a new pull request, #5875:
URL: https://github.com/apache/netbeans/pull/5875
`shouldAcceptWildcardCertificate(org.netbeans.modules.xml.retriever.impl.SecureURLResourceRetrieverTest)` started failing with:
```
[junit] PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
[junit] javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed
[junit] at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)
...
```
https://github.com/apache/netbeans/actions/runs/4778711192/jobs/8495573338
since the cert of the test url expired. I switched it to wikipedia.org since they are using a wildcard cert too (suggestions for better options appreciated).
we would have to get this both, into master and delivery. This is based on delivery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5875: update wildcard cert test case url since badssl expired
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5875:
URL: https://github.com/apache/netbeans/pull/5875#issuecomment-1519218739
closing since the cert has been updated and the tests are passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5875: update wildcard cert test case url since badssl expired
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5875:
URL: https://github.com/apache/netbeans/pull/5875#issuecomment-1519129924
This is already reported: https://github.com/chromium/badssl.com/issues/521
It looks like badssl has issues updating certificates, but it is done, given this is on a weekend, I would give it a few days. The wikipedia certificate looks like a bad example as it contains the target hostname directly, which kind of defeats the test. If this really needs to change at least `https://en.wikipedia.org` should be used. However I don't see a guarantee, that wikipedia does not switch to SNI + individual certificates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien closed pull request #5875: update wildcard cert test case url since badssl expired
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien closed pull request #5875: update wildcard cert test case url since badssl expired
URL: https://github.com/apache/netbeans/pull/5875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5875: update wildcard cert test case url since badssl expired
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5875:
URL: https://github.com/apache/netbeans/pull/5875#issuecomment-1519131480
> The wikipedia certificate looks like a bad example as it contains the target hostname directly
i agree. I couldn't come up with a better URL we could use which only sets a wildcard without the domain itself.
Lets wait a bit maybe badssl can update the cert soon. But if this doesn't happen soon we should turn the test off, like the other one a few lines below.
https://github.com/apache/netbeans/blob/f8e9e4c053a837b84554c682eae216e34a2b7355/ide/xml.retriever/test/unit/src/org/netbeans/modules/xml/retriever/impl/SecureURLResourceRetrieverTest.java#L80-L82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists