You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/12 05:07:49 UTC

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #6902: RealtimeToOfflineSegmentsTask not handle null values properly

Jackie-Jiang opened a new issue #6902:
URL: https://github.com/apache/incubator-pinot/issues/6902


   1. Null value vector cannot be created on the output segments
   2. New added columns can cause NPE
   
   The root cause of the issue is that we skip the record transformer within the `SegmentProcessorFramework`. For existing null values, `_nullValueFields` are not preserved within the `GenericRow`; For new added columns, the field will be `null` without the `NullValueTransformer`. Besides these issues, the new added derived column won't be generated as well.
   
   The solution is:
   1. Backfill null values to the `GenericRow` in the `PinotSegmentRecordReader`
   2. Use the default record transformer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6902: RealtimeToOfflineSegmentsTask not handle null values properly

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #6902:
URL: https://github.com/apache/incubator-pinot/issues/6902#issuecomment-842579774


   #6922 Support null values in `PinotSegmentRecordReader`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6902: RealtimeToOfflineSegmentsTask not handle null values properly

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #6902:
URL: https://github.com/apache/incubator-pinot/issues/6902#issuecomment-853587275


   #7013 Preserve null values in `SegmentMapper`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6902: RealtimeToOfflineSegmentsTask not handle null values properly

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #6902:
URL: https://github.com/apache/incubator-pinot/issues/6902#issuecomment-853587275


   #7013 Preserve null values in `SegmentMapper`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org