You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/08/25 23:13:58 UTC
Review Request 37772: Fix RPM building.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-851
https://issues.apache.org/jira/browse/AURORA-851
Repository: aurora-packaging
Description
-------
This addresses several things needed to get RPM builds working. The major change is the specification of an RPM Epoch, which will allow the desired version ordering for nightly vs released versions. If you would like some light reading on this topic, you can find it here: http://www.rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html
Diffs
-----
builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
specs/rpm/aurora.init.sh
specs/rpm/aurora.logrotate
specs/rpm/aurora.service
specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
specs/rpm/aurora.startup.sh
specs/rpm/aurora.sysconfig
specs/rpm/clusters.json
specs/rpm/thermos-observer.init.sh
specs/rpm/thermos-observer.logrotate
specs/rpm/thermos-observer.service
specs/rpm/thermos-observer.startup.sh
specs/rpm/thermos-observer.sysconfig
Diff: https://reviews.apache.org/r/37772/diff/
Testing
-------
Successfully ran
```
./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
```
Thanks,
Bill Farner
Re: Review Request 37772: Fix RPM building.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 25, 2015, 9:45 p.m., Maxim Khutornenko wrote:
> > specs/rpm/aurora.spec, lines 62-72
> > <https://reviews.apache.org/r/37772/diff/2/?file=1053012#file1053012line62>
> >
> > nit: could be easier to follow if source definitions matched the below install sequence.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/#review96494
-----------------------------------------------------------
On Aug. 25, 2015, 9:38 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37772/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 9:38 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-851
> https://issues.apache.org/jira/browse/AURORA-851
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Fix references when copying package sources files.
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
> specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
> specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
> specs/rpm/aurora.init.sh
> specs/rpm/aurora.logrotate
> specs/rpm/aurora.service
> specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
> specs/rpm/aurora.startup.sh
> specs/rpm/aurora.sysconfig
> specs/rpm/clusters.json
> specs/rpm/thermos-observer.init.sh
> specs/rpm/thermos-observer.logrotate
> specs/rpm/thermos-observer.service
> specs/rpm/thermos-observer.startup.sh
> specs/rpm/thermos-observer.sysconfig
>
> Diff: https://reviews.apache.org/r/37772/diff/
>
>
> Testing
> -------
>
> Successfully ran
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37772: Fix RPM building.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/#review96494
-----------------------------------------------------------
Ship it!
specs/rpm/aurora.spec (lines 62 - 72)
<https://reviews.apache.org/r/37772/#comment151883>
nit: could be easier to follow if source definitions matched the below install sequence.
- Maxim Khutornenko
On Aug. 26, 2015, 4:38 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37772/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 4:38 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-851
> https://issues.apache.org/jira/browse/AURORA-851
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> Fix references when copying package sources files.
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
> specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
> specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
> specs/rpm/aurora.init.sh
> specs/rpm/aurora.logrotate
> specs/rpm/aurora.service
> specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
> specs/rpm/aurora.startup.sh
> specs/rpm/aurora.sysconfig
> specs/rpm/clusters.json
> specs/rpm/thermos-observer.init.sh
> specs/rpm/thermos-observer.logrotate
> specs/rpm/thermos-observer.service
> specs/rpm/thermos-observer.startup.sh
> specs/rpm/thermos-observer.sysconfig
>
> Diff: https://reviews.apache.org/r/37772/diff/
>
>
> Testing
> -------
>
> Successfully ran
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37772: Fix RPM building.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 10:45 a.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
Numerically arranged source files.
Bugs: AURORA-851
https://issues.apache.org/jira/browse/AURORA-851
Repository: aurora-packaging
Description
-------
Fix references when copying package sources files.
Diffs (updated)
-----
builder/deb/ubuntu-trusty/build.sh bb2b79962db90fe864ea89b824e92d1a91b5a6cb
specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
specs/rpm/aurora.init.sh
specs/rpm/aurora.logrotate
specs/rpm/aurora.service
specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
specs/rpm/aurora.startup.sh
specs/rpm/aurora.sysconfig
specs/rpm/clusters.json
specs/rpm/thermos-observer.init.sh
specs/rpm/thermos-observer.logrotate
specs/rpm/thermos-observer.service
specs/rpm/thermos-observer.startup.sh
specs/rpm/thermos-observer.sysconfig
Diff: https://reviews.apache.org/r/37772/diff/
Testing
-------
Successfully ran
```
./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
```
Thanks,
Bill Farner
Re: Review Request 37772: Fix RPM building.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 9:38 p.m.)
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-851
https://issues.apache.org/jira/browse/AURORA-851
Repository: aurora-packaging
Description (updated)
-------
Fix references when copying package sources files.
Diffs (updated)
-----
builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
specs/rpm/aurora.init.sh
specs/rpm/aurora.logrotate
specs/rpm/aurora.service
specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
specs/rpm/aurora.startup.sh
specs/rpm/aurora.sysconfig
specs/rpm/clusters.json
specs/rpm/thermos-observer.init.sh
specs/rpm/thermos-observer.logrotate
specs/rpm/thermos-observer.service
specs/rpm/thermos-observer.startup.sh
specs/rpm/thermos-observer.sysconfig
Diff: https://reviews.apache.org/r/37772/diff/
Testing
-------
Successfully ran
```
./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
```
Thanks,
Bill Farner
Re: Review Request 37772: Fix RPM building.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/#review96450
-----------------------------------------------------------
specs/rpm/Makefile (line 33)
<https://reviews.apache.org/r/37772/#comment151837>
Shouldn't nightly also use AURORA_EPOCH? It's unlikely but possible to envision multiple invocations of a nightly build interleaved with commits producing unexpected results.
In fact, would it make sense to make AURORA_EPOCH global and auto-incrementing (e.g. off of system time)?
- Maxim Khutornenko
On Aug. 25, 2015, 9:13 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37772/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 9:13 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-851
> https://issues.apache.org/jira/browse/AURORA-851
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> This addresses several things needed to get RPM builds working. The major change is the specification of an RPM Epoch, which will allow the desired version ordering for nightly vs released versions. If you would like some light reading on this topic, you can find it here: http://www.rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
> builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
> specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
> specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
> specs/rpm/aurora.init.sh
> specs/rpm/aurora.logrotate
> specs/rpm/aurora.service
> specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
> specs/rpm/aurora.startup.sh
> specs/rpm/aurora.sysconfig
> specs/rpm/clusters.json
> specs/rpm/thermos-observer.init.sh
> specs/rpm/thermos-observer.logrotate
> specs/rpm/thermos-observer.service
> specs/rpm/thermos-observer.startup.sh
> specs/rpm/thermos-observer.sysconfig
>
> Diff: https://reviews.apache.org/r/37772/diff/
>
>
> Testing
> -------
>
> Successfully ran
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37772: Fix RPM building.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Aug. 25, 2015, 11:12 p.m., Kevin Sweeney wrote:
> > specs/rpm/Makefile, lines 37-38
> > <https://reviews.apache.org/r/37772/diff/1/?file=1052463#file1052463line37>
> >
> > This is weird as a user will never be able to upgrade from a release version to a nightly.
Isn't version global across RPM builds?
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/#review96443
-----------------------------------------------------------
On Aug. 25, 2015, 9:13 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37772/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 9:13 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-851
> https://issues.apache.org/jira/browse/AURORA-851
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> This addresses several things needed to get RPM builds working. The major change is the specification of an RPM Epoch, which will allow the desired version ordering for nightly vs released versions. If you would like some light reading on this topic, you can find it here: http://www.rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
> builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
> specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
> specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
> specs/rpm/aurora.init.sh
> specs/rpm/aurora.logrotate
> specs/rpm/aurora.service
> specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
> specs/rpm/aurora.startup.sh
> specs/rpm/aurora.sysconfig
> specs/rpm/clusters.json
> specs/rpm/thermos-observer.init.sh
> specs/rpm/thermos-observer.logrotate
> specs/rpm/thermos-observer.service
> specs/rpm/thermos-observer.startup.sh
> specs/rpm/thermos-observer.sysconfig
>
> Diff: https://reviews.apache.org/r/37772/diff/
>
>
> Testing
> -------
>
> Successfully ran
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37772: Fix RPM building.
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 25, 2015, 4:12 p.m., Kevin Sweeney wrote:
> > specs/rpm/Makefile, lines 37-38
> > <https://reviews.apache.org/r/37772/diff/1/?file=1052463#file1052463line37>
> >
> > This is weird as a user will never be able to upgrade from a release version to a nightly.
>
> Maxim Khutornenko wrote:
> Isn't version global across RPM builds?
This was a misunderstanding of how epochs are used for version identification. I will back out that part of the patch.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/#review96443
-----------------------------------------------------------
On Aug. 25, 2015, 2:13 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37772/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 2:13 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-851
> https://issues.apache.org/jira/browse/AURORA-851
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> This addresses several things needed to get RPM builds working. The major change is the specification of an RPM Epoch, which will allow the desired version ordering for nightly vs released versions. If you would like some light reading on this topic, you can find it here: http://www.rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
> builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
> specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
> specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
> specs/rpm/aurora.init.sh
> specs/rpm/aurora.logrotate
> specs/rpm/aurora.service
> specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
> specs/rpm/aurora.startup.sh
> specs/rpm/aurora.sysconfig
> specs/rpm/clusters.json
> specs/rpm/thermos-observer.init.sh
> specs/rpm/thermos-observer.logrotate
> specs/rpm/thermos-observer.service
> specs/rpm/thermos-observer.startup.sh
> specs/rpm/thermos-observer.sysconfig
>
> Diff: https://reviews.apache.org/r/37772/diff/
>
>
> Testing
> -------
>
> Successfully ran
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37772: Fix RPM building.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37772/#review96443
-----------------------------------------------------------
specs/rpm/Makefile (lines 37 - 38)
<https://reviews.apache.org/r/37772/#comment151814>
This is weird as a user will never be able to upgrade from a release version to a nightly.
- Kevin Sweeney
On Aug. 25, 2015, 2:13 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37772/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 2:13 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-851
> https://issues.apache.org/jira/browse/AURORA-851
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> This addresses several things needed to get RPM builds working. The major change is the specification of an RPM Epoch, which will allow the desired version ordering for nightly vs released versions. If you would like some light reading on this topic, you can find it here: http://www.rpm.org/max-rpm-snapshot/s1-rpm-depend-manual-dependencies.html
>
>
> Diffs
> -----
>
> builder/deb/ubuntu-trusty/build.sh 9c162c728a11a52fb3918dc41f899eb64e3c1084
> builder/rpm/centos-7/build.sh 9e8eae94a09d013d01ea405ecb2e554d348e2ce8
> specs/rpm/Makefile 77605fe4817ada3cb4601b754a5e4980f8fd1e45
> specs/rpm/README.md 2432dc7d1de0ae1becd36a914a446a4211f6c177
> specs/rpm/aurora.init.sh
> specs/rpm/aurora.logrotate
> specs/rpm/aurora.service
> specs/rpm/aurora.spec 22c107e4dd012d516a11e25a1d1cb6e702e6a24e
> specs/rpm/aurora.startup.sh
> specs/rpm/aurora.sysconfig
> specs/rpm/clusters.json
> specs/rpm/thermos-observer.init.sh
> specs/rpm/thermos-observer.logrotate
> specs/rpm/thermos-observer.service
> specs/rpm/thermos-observer.startup.sh
> specs/rpm/thermos-observer.sysconfig
>
> Diff: https://reviews.apache.org/r/37772/diff/
>
>
> Testing
> -------
>
> Successfully ran
> ```
> ./build-artifact.sh builder/rpm/centos-7 ~/apache-aurora-0.10.0_SNAPSHOT.2015.08.25.tar.gz 0.10.0_SNAPSHOT.2015.08.25
> ```
>
>
> Thanks,
>
> Bill Farner
>
>