You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Ted Kirby (JIRA)" <ji...@apache.org> on 2007/01/16 14:13:27 UTC
[jira] Created: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Add property substitution capability in the config.xml and plan files
---------------------------------------------------------------------
Key: GERONIMO-2735
URL: https://issues.apache.org/jira/browse/GERONIMO-2735
Project: Geronimo
Issue Type: New Feature
Security Level: public (Regular issues)
Affects Versions: 2.0-M1, 1.1.1, 1.1.x
Environment: All
Reporter: Ted Kirby
Priority: Minor
Allow property substitution as it works in maven, Spring, and JBoss.
Allow a geronimo.properties type file. In that file, allow something like this:
tomcat.port=9090
tomcat.listen.ip=10.0.0.7
In the config.xml, then allow the following:
...
<module name="...">
<gbean name="TomcatConnector">
<attribute name="port">${tomcat.port}</attribute>
<attribute name="host">${tomcat.listen.ip}</attribute>
</gbean>
</module>
The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reopened GERONIMO-2735:
------------------------------------
This needs some cleanup.
1. All the variables except portOffset start with "Plan" which is not appropriate
2. both environment variables and system properties are just stuffed into the substitution list willy-nilly. This could easily let other peoples settings interfere with geronimo. Our properties should start with an unambiguous prefix such as org.apache.geronimo.config.substitution.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assignee: David Jencks
> Priority: Minor
> Fix For: 2.0-M6
>
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514675 ]
David Jencks commented on GERONIMO-2735:
----------------------------------------
fixed in trunk (now 2.1-SNAPSHOT) in rev 558792. Need to port to 2.0.0 and fix documentation at http://cwiki.apache.org/confluence/display/GMOxDOC20/Multiple+Repositories
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assignee: David Jencks
> Priority: Minor
> Fix For: 2.0-M6
>
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reassigned GERONIMO-2735:
--------------------------------------
Assignee: David Jencks
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assigned To: David Jencks
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477807 ]
David Jencks commented on GERONIMO-2735:
----------------------------------------
I agree it would be beneficial in 1.2 but I'm worried that it will be very risky. In trunk I'm finding that at least one of the micro-servers (jsr88-deployer) needed changes to get the jexl library into the appropriate classloader. I have no confidence in my ability to quickly find all the places it would be needed in 1.2.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assigned To: David Jencks
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488140 ]
Anita Kulshreshtha commented on GERONIMO-2735:
----------------------------------------------
rev 527596
- Updated config-substitutions.properties in boilerplate-minimal
- added portOffset to config.xml in geronimo-jetty6-jee5 and geronimo-tomcat6-jee5 assemblies
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assigned To: David Jencks
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "Jeff Genender (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477802 ]
Jeff Genender commented on GERONIMO-2735:
-----------------------------------------
Good work Ted and David. However, I think it would be beneficial to get into 1.2. I know there are folks who need this.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assigned To: David Jencks
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477738 ]
David Jencks commented on GERONIMO-2735:
----------------------------------------
I worked on trunk (2.0) and reworked the patch substantially. There's now a small example in the geronimo-jetty6-jee5 config.xml.
rev 514355.
features:
- jexl expressions in ${} such as ${httpPort + portOffset}
- expressions are only evaluated when gbeanData overrides are being applied, not on set.
- default properties file is var/config/config-substitutions.properties
- refactored most of the LocalAttributeManager related classes to use generics.
If no one objects or has a better idea in a few days I'll make more extensive use of this feature in our config.xmls.
I don't think it's practical to try to get this into the 1.2 branch.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assigned To: David Jencks
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (GERONIMO-2735) Add property substitution capability in the config.xml and plan files
Posted by Ted Kirby <te...@gmail.com>.
On 2/20/07, David Jencks <da...@yahoo.com> wrote:
> Before I run ahead and apply this I'd like to make sure this is the
> approach we all agree on.
>
> I think there are 2 choices for how to do this:
>
> 1. as done in the patch, where the config.xml has explicit
> substitutions possibly within other text and the substitution
> property names have no connection with the attribute names they are in.
I like this approach in that, as implied by the example, variables can
be named, and applied across multiple modules.
> 2. supplying complete attribute values for arbitrary gbeans whether
> or not those gbeans are mentioned in the config.xml. This would
> mean the properties file would have something like
>
> module/gbean/attributeName=attributeValue
I am sure I am not fully grasping the intention and implications here,
but nonetheless :), here are my comments:
1. I think this loses the notion of a parameter name and a
substitution value, as in the examples above.
2. What is interesting here is changing values that are not in
config.xml. On the one hand, this can be an easy way to change
values. On the other, config.xml serves a a single point of reference
for attribute values, in particular listing those that are mutable
there. This notion breaks that tradition, and offers another file to
find to see where and what values are set, as well as allowing any
value to be set. Adding any properties file adds another place to
look, which is what the first option does, too.
Would you want to consider combining the two by doing both? Two
separate files could be used, or a / in the attribute name could
denote this new second semantics. Such a combination would allow for
substitutions of the type in option 1.
> I can see advantages to both.
>
> thanks
> david jencks
>
> On Jan 25, 2007, at 2:59 PM, Ted Kirby (JIRA) wrote:
>
> >
> > [ https://issues.apache.org/jira/browse/GERONIMO-2735?
> > page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
> >
> > Ted Kirby updated GERONIMO-2735:
> > --------------------------------
> >
> > Attachment: JIRA2735.2.0.patch
> >
> > Here is a patch for ag 2.0, based on v499398 code.
> >
> >> Add property substitution capability in the config.xml and plan files
> >> ---------------------------------------------------------------------
> >>
> >> Key: GERONIMO-2735
> >> URL: https://issues.apache.org/jira/browse/
> >> GERONIMO-2735
> >> Project: Geronimo
> >> Issue Type: New Feature
> >> Security Level: public(Regular issues)
> >> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> >> Environment: All
> >> Reporter: Ted Kirby
> >> Priority: Minor
> >> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
> >>
> >>
> >> Allow property substitution as it works in maven, Spring, and JBoss.
> >> Allow a geronimo.properties type file. In that file, allow
> >> something like this:
> >> tomcat.port=9090
> >> tomcat.listen.ip=10.0.0.7
> >> In the config.xml, then allow the following:
> >> ...
> >> <module name="...">
> >> <gbean name="TomcatConnector">
> >> <attribute name="port">${tomcat.port}</attribute>
> >> <attribute name="host">${tomcat.listen.ip}</attribute>
> >> </gbean>
> >> </module>
> >> The server reads the property file on boot (if one exists). When
> >> the config.xml is processed, it substitutes the declared property.
> >> Properties might also come from a GBean.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
>
>
Re: [jira] Updated: (GERONIMO-2735) Add property substitution capability in the config.xml and plan files
Posted by David Jencks <da...@yahoo.com>.
Before I run ahead and apply this I'd like to make sure this is the
approach we all agree on.
I think there are 2 choices for how to do this:
1. as done in the patch, where the config.xml has explicit
substitutions possibly within other text and the substitution
property names have no connection with the attribute names they are in.
2. supplying complete attribute values for arbitrary gbeans whether
or not those gbeans are mentioned in the config.xml. This would
mean the properties file would have something like
module/gbean/attributeName=attributeValue
I can see advantages to both.
thanks
david jencks
On Jan 25, 2007, at 2:59 PM, Ted Kirby (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/GERONIMO-2735?
> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Ted Kirby updated GERONIMO-2735:
> --------------------------------
>
> Attachment: JIRA2735.2.0.patch
>
> Here is a patch for ag 2.0, based on v499398 code.
>
>> Add property substitution capability in the config.xml and plan files
>> ---------------------------------------------------------------------
>>
>> Key: GERONIMO-2735
>> URL: https://issues.apache.org/jira/browse/
>> GERONIMO-2735
>> Project: Geronimo
>> Issue Type: New Feature
>> Security Level: public(Regular issues)
>> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
>> Environment: All
>> Reporter: Ted Kirby
>> Priority: Minor
>> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>>
>>
>> Allow property substitution as it works in maven, Spring, and JBoss.
>> Allow a geronimo.properties type file. In that file, allow
>> something like this:
>> tomcat.port=9090
>> tomcat.listen.ip=10.0.0.7
>> In the config.xml, then allow the following:
>> ...
>> <module name="...">
>> <gbean name="TomcatConnector">
>> <attribute name="port">${tomcat.port}</attribute>
>> <attribute name="host">${tomcat.listen.ip}</attribute>
>> </gbean>
>> </module>
>> The server reads the property file on boot (if one exists). When
>> the config.xml is processed, it substitutes the declared property.
>> Properties might also come from a GBean.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Updated: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby updated GERONIMO-2735:
--------------------------------
Attachment: JIRA2735.2.0.patch
Here is a patch for ag 2.0, based on v499398 code.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-2735) Add property substitution
capability in the config.xml and plan files
Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Kirby updated GERONIMO-2735:
--------------------------------
Attachment: JIRA2735.1.1.1.patch
Here is a patch for 1.1.1 based on Rev447393 code.
Here is the approach, from dev list discussion:
Substitution is performed by the new substituteVariables method of GBeanOverride, which is invoked in setAttribute. Any values with substituted text are saved in a new unsubstitutedAttribute Map. These raw, unsubstituted values are then saved to config.xml by a change in writeXML.
Support for a properties file is added in LocalAttributeManager. A propertiesFile attribute is added to this GBean. It works like configFile, relative to GERONIMO_HOME. The default properties file name is var/config/geronimo.properties, set in the j2ee-system module, like config.xml.
The substitution value hierarchy, as specified in the new GBeanOverride. getVariableValue method, is:
1. system properties
2. environment variables
3. properties file
Nested/indirect variables, such as ${var{$number}}, are not supported, but would make for an interesting enhancement.
GBeanOverride.substituteVariables uses a static LocalAttributeManager.getProperty() method to interrogate the properties loaded from the properties file. I think this is a bit of hack, and solicit input on a better approach. I supposed a reference could be passed in through ServerOverride and ConfigurationOverride.
I will now port this work to AG20, and post a patch for it subsequently.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-2735) Add property substitution capability
in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-2735.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.0-M6
I think this is as implemented as its going to get soon (great job anita!). I don't see anyone jumping up and down putting it into 1.2 and checking it works.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assignee: David Jencks
> Priority: Minor
> Fix For: 2.0-M6
>
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-2735) Add property substitution capability
in the config.xml and plan files
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-2735.
----------------------------------
Resolution: Fixed
Fix Version/s: (was: 2.0-M6)
2.0-M7
I updated http://cwiki.apache.org/confluence/display/GMOxDOC20/Multiple+Repositories
and merged the last set of changes to the 2.0 branch in rev 558873.
The wiki page is not the ideal place to document this, but it's better than nothing.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assignee: David Jencks
> Priority: Minor
> Fix For: 2.0-M7
>
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.