You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/12/19 18:05:00 UTC
[jira] [Commented] (GEODE-4841) Switch declaration of
HashMapOfPools to 'using' in PoolManagerImpl
[ https://issues.apache.org/jira/browse/GEODE-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725238#comment-16725238 ]
ASF subversion and git services commented on GEODE-4841:
--------------------------------------------------------
Commit fe67eb77f49dcb2aed67400f21b7e2a818d08cc1 in geode-native's branch refs/heads/develop from Matthew Reddington
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=fe67eb7 ]
GEODE-4841: Changed typedef to using statement. (#419)
- Moved the definition into its own header to remove
declaration duplication.
- Removed errant header included in CMake file.
> Switch declaration of HashMapOfPools to 'using' in PoolManagerImpl
> ------------------------------------------------------------------
>
> Key: GEODE-4841
> URL: https://issues.apache.org/jira/browse/GEODE-4841
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently this is a convenience typedef in the header file, and comes with all the associated baggage - pollutes the global namespace, etc. We should be good C++11 citizens and remove the typedef, replacing it with a 'using' statement at class scope closer to where we actually need the type. Or, just declare variables of this type as 'auto' in PoolManagerImpl, even more convenient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)