You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@opennlp.apache.org by kinow <gi...@git.apache.org> on 2017/05/19 10:55:24 UTC

[GitHub] opennlp-site pull request #14: OPENNLP-1067: Use variables in jbake.properti...

GitHub user kinow opened a pull request:

    https://github.com/apache/opennlp-site/pull/14

    OPENNLP-1067: Use variables in jbake.properties file to specify version used in site generation.

    We cannot use pom.xml, as the feature in the JBake maven plug-in was released with the jbake-maven-plugin 0.2.0. The plug-in was released in GitHub (i.e. tagged), however, never released to Maven Central (see https://github.com/ingenieux/jbake-maven-plugin/issues/18).
    
    For now we can use jbake.properties. Better than manually changing the value in several places :-)
    
    Notice the manual URL is set to 1.7.2, as we do not have the manual generated for 1.8.0 - TBH I do not know how to generate it. And that we have a property for the next version, as we have an example SNAPSHOT usage for OpenNLP Tools module - not sure if we really need that...
    
    Cheers
    Bruno

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kinow/opennlp-site OPENNLP-1067

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp-site/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit a2008f3def55f80112ac9749f1c858da85232fd4
Author: Bruno P. Kinoshita <br...@yahoo.com.br>
Date:   2017-05-19T10:52:19Z

    OPENNLP-1067: Use variables in jbake.properties file to specify version used in site generation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp-site pull request #14: OPENNLP-1067: Use variables in jbake.properti...

Posted by kottmann <gi...@git.apache.org>.

Github user kottmann commented on a diff in the pull request:

    https://github.com/apache/opennlp-site/pull/14#discussion_r117455933
  
    --- Diff: src/main/jbake/content/maven-dependency.ad ---
    @@ -35,59 +34,75 @@ all transient dependencies are resolved automatically.
     
     To use the OpenNLP Tools define the following dependency:
     
    -
    -    <dependency>
    -      <groupId>org.apache.opennlp</groupId>
    -      <artifactId>opennlp-tools</artifactId>
    -      <version>1.7.2</version>
    -    </dependency>
    -
    +[source,xml,indent=0,subs=attributes+]
    +----
    +<dependency>
    +  <groupId>org.apache.opennlp</groupId>
    +  <artifactId>opennlp-tools</artifactId>
    +  <version>{opennlp_version}</version>
    +</dependency>
    +----
     
     ## OpenNLP UIMA Annotators Dependency
     
     To use the OpenNLP UIMA Annotators define the following dependency:
     
    -    <dependency>
    -      <groupId>org.apache.opennlp</groupId>
    -      <artifactId>opennlp-uima</artifactId>
    -      <version>1.7.2</version>
    -    </dependency>
    +[source,xml,indent=0,subs=attributes+]
    +----
    +<dependency>
    +  <groupId>org.apache.opennlp</groupId>
    +  <artifactId>opennlp-uima</artifactId>
    +  <version>{opennlp_version}</version>
    +</dependency>
    +----
     
     ## OpenNLP Morfologik AddOn Dependency
     
     To use the OpenNLP Morfologik-Addon define the following dependency:
     
    -    <dependency>
    -      <groupId>org.apache.opennlp</groupId>
    -      <artifactId>opennlp-morfologik-addon</artifactId>
    -      <version>1.7.2</version>
    -    </dependency>
    +[source,xml,indent=0,subs=attributes+]
    +----
    +<dependency>
    +  <groupId>org.apache.opennlp</groupId>
    +  <artifactId>opennlp-morfologik-addon</artifactId>
    +  <version>{opennlp_version}</version>
    +</dependency>
    +----
     
     ## OpenNLP Brat Annotator Dependency
     
     To use the OpenNLP UIMA Annotators define the following dependency:
     
    -    <dependency>
    -      <groupId>org.apache.opennlp</groupId>
    -      <artifactId>opennlp-brat-annotator</artifactId>
    -      <version>1.7.2</version>
    -    </dependency>
    +[source,xml,indent=0,subs=attributes+]
    +----
    +<dependency>
    +  <groupId>org.apache.opennlp</groupId>
    +  <artifactId>opennlp-brat-annotator</artifactId>
    +  <version>{opennlp_version}</version>
    +</dependency>
    +----
     
     ## OpenNLP Tools SNAPSHOT Dependency
     
     To use the current trunk version define the following dependency:
     
    -    <dependency>
    -      <groupId>org.apache.opennlp</groupId>
    -      <artifactId>opennlp-tools</artifactId>
    -      <version>1.7.3-SNAPSHOT</version>
    -    </dependency>
    +[source,xml,indent=0,subs=attributes+]
    +----
    +<dependency>
    +  <groupId>org.apache.opennlp</groupId>
    +  <artifactId>opennlp-tools</artifactId>
    +  <version>{opennlp_next_version}</version>
    +</dependency>
    +----
     
     The SNAPSHOT dependency requires the following repository:
     
    -    <repositories>
    -      <repository>
    -        <id>apache opennlp snapshot</id>
    -        <url>https://repository.apache.org/content/repositories/snapshots/</url>
    -      </repository>
    -    </repositories>
    \ No newline at end of file
    +[source,xml,indent=0,subs=attributes+]
    +----
    +<repositories>
    +  <repository>
    +    <id>apache opennlp snapshot</id>
    +    <url>https://repository.apache.org/content/repositories/snapshots/</url>
    +  </repository>
    +</repositories>
    +----
    --- End diff --
    
    Add a new line here, files are supposed to end with new line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---