You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/22 05:55:11 UTC

[GitHub] [kafka] vinothchandar commented on a change in pull request #8462: KAFKA-9846: Filter active tasks for running state in KafkaStreams#allLocalStorePartitionLags()

vinothchandar commented on a change in pull request #8462:
URL: https://github.com/apache/kafka/pull/8462#discussion_r412690139



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java
##########
@@ -295,9 +295,10 @@ public void onRestoreEnd(final TopicPartition topicPartition, final String store
                 }
             });
 
-            restartedStreams.start();
+            // Wait till the restarted instance reaches running, after restoring
+            startApplicationAndWaitUntilRunning(Collections.singletonList(restartedStreams), Duration.ofSeconds(60));

Review comment:
       this is the actual fix for flaky test .. 
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org