You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/13 17:03:56 UTC

[GitHub] [arrow] pitrou opened a new pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

pitrou opened a new pull request #12145:
URL: https://github.com/apache/arrow/pull/12145


   - Stack smashing crash because of excessive size given to utf8proc.
   - Heap access crash because of insufficient scratch space in levenshtein calculation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1012330688


   @github-actions crossbow submit -g cpp


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1012382166


   Note the test-fedora-33-cpp failure should be fixed by https://github.com/apache/arrow/pull/12146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs closed pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #12145:
URL: https://github.com/apache/arrow/pull/12145


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1012340843






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1013091190


   Benchmark runs are scheduled for baseline = 99f7c3cf3e6c2a9555ceff3d48ef73e485ede546 and contender = fc6d408f5adf09cfcf1949354df396edf6e3e4ab. fc6d408f5adf09cfcf1949354df396edf6e3e4ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c71c378aa57348a7982f3367bef2d820...d0196080386948dc82073a9e4071f595/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6dda696a7573437f923d6a239b202db1...5620fb53be9b4d5c8fb61249c7e1ab20/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6a5de60d0f324c31a39d3122033e8804...9cba2e4339d64dc2910e792af6381e6c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1013091190


   Benchmark runs are scheduled for baseline = 99f7c3cf3e6c2a9555ceff3d48ef73e485ede546 and contender = fc6d408f5adf09cfcf1949354df396edf6e3e4ab. fc6d408f5adf09cfcf1949354df396edf6e3e4ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c71c378aa57348a7982f3367bef2d820...d0196080386948dc82073a9e4071f595/)
   [Finished :arrow_down:2.69% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6dda696a7573437f923d6a239b202db1...5620fb53be9b4d5c8fb61249c7e1ab20/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6a5de60d0f324c31a39d3122033e8804...9cba2e4339d64dc2910e792af6381e6c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1013091190


   Benchmark runs are scheduled for baseline = 99f7c3cf3e6c2a9555ceff3d48ef73e485ede546 and contender = fc6d408f5adf09cfcf1949354df396edf6e3e4ab. fc6d408f5adf09cfcf1949354df396edf6e3e4ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c71c378aa57348a7982f3367bef2d820...d0196080386948dc82073a9e4071f595/)
   [Finished :arrow_down:2.69% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6dda696a7573437f923d6a239b202db1...5620fb53be9b4d5c8fb61249c7e1ab20/)
   [Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6a5de60d0f324c31a39d3122033e8804...9cba2e4339d64dc2910e792af6381e6c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1012331855


   @augustoasilva @pravindra @ViniciusSouzaRoque Can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1012349601


   Revision: fdbf185d96a44267ced051a19f499464f5f2f51c
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-1395](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1395)
   
   |Task|Status|
   |----|------|
   |test-build-cpp-fuzz|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-build-cpp-fuzz)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-build-cpp-fuzz)|
   |test-conda-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-conda-cpp)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-conda-cpp)|
   |test-conda-cpp-valgrind|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-1395-azure-test-conda-cpp-valgrind)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1395-azure-test-conda-cpp-valgrind)|
   |test-debian-10-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-debian-10-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-debian-10-cpp-amd64)|
   |test-debian-10-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-debian-10-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-debian-10-cpp-i386)|
   |test-debian-11-cpp-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-debian-11-cpp-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-debian-11-cpp-amd64)|
   |test-debian-11-cpp-i386|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-debian-11-cpp-i386)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-debian-11-cpp-i386)|
   |test-fedora-33-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-fedora-33-cpp)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-fedora-33-cpp)|
   |test-ubuntu-18.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-18.04-cpp)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-18.04-cpp)|
   |test-ubuntu-18.04-cpp-release|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-18.04-cpp-release)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-18.04-cpp-release)|
   |test-ubuntu-18.04-cpp-static|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-18.04-cpp-static)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-18.04-cpp-static)|
   |test-ubuntu-20.04-cpp|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-20.04-cpp)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-20.04-cpp)|
   |test-ubuntu-20.04-cpp-14|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-20.04-cpp-14)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-20.04-cpp-14)|
   |test-ubuntu-20.04-cpp-17|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-20.04-cpp-17)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-20.04-cpp-17)|
   |test-ubuntu-20.04-cpp-bundled|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-20.04-cpp-bundled)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-20.04-cpp-bundled)|
   |test-ubuntu-20.04-cpp-thread-sanitizer|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-1395-github-test-ubuntu-20.04-cpp-thread-sanitizer)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1395-github-test-ubuntu-20.04-cpp-thread-sanitizer)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ViniciusSouzaRoque commented on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
ViniciusSouzaRoque commented on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1012988726


   > @augustoasilva @pravindra @ViniciusSouzaRoque Can you take a look?
   
   ok, everything right with this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #12145: ARROW-15326: [C++] Fix Gandiva crashes

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12145:
URL: https://github.com/apache/arrow/pull/12145#issuecomment-1013091190


   Benchmark runs are scheduled for baseline = 99f7c3cf3e6c2a9555ceff3d48ef73e485ede546 and contender = fc6d408f5adf09cfcf1949354df396edf6e3e4ab. fc6d408f5adf09cfcf1949354df396edf6e3e4ab is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c71c378aa57348a7982f3367bef2d820...d0196080386948dc82073a9e4071f595/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6dda696a7573437f923d6a239b202db1...5620fb53be9b4d5c8fb61249c7e1ab20/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6a5de60d0f324c31a39d3122033e8804...9cba2e4339d64dc2910e792af6381e6c/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org