You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/18 03:36:07 UTC
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1353: Ftr: Support Custom Registry GroupName on Nacos
codecov-commenter edited a comment on pull request #1353:
URL: https://github.com/apache/dubbo-go/pull/1353#issuecomment-890683481
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1353](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec7214c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/0aac960e6219d4138ac2f72ea19ad0d45857784d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0aac960) will **increase** coverage by `12.95%`.
> The diff coverage is `87.50%`.
> :exclamation: Current head ec7214c differs from pull request most recent head 1184df2. Consider uploading reports for the commit 1184df2 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1353 +/- ##
===========================================
+ Coverage 41.82% 54.78% +12.95%
===========================================
Files 259 272 +13
Lines 15120 14749 -371
===========================================
+ Hits 6324 8080 +1756
+ Misses 8058 5788 -2270
- Partials 738 881 +143
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [registry/nacos/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvbGlzdGVuZXIuZ28=) | `81.30% <77.77%> (+2.17%)` | :arrow_up: |
| [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `76.60% <100.00%> (+0.17%)` | :arrow_up: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `45.23% <100.00%> (+0.88%)` | :arrow_up: |
| [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `17.97% <0.00%> (-48.35%)` | :arrow_down: |
| [config/metric\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldHJpY19jb25maWcuZ28=) | `0.00% <0.00%> (-21.43%)` | :arrow_down: |
| [metadata/report/etcd/report.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2V0Y2QvcmVwb3J0Lmdv) | `53.62% <0.00%> (-8.60%)` | :arrow_down: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `68.33% <0.00%> (-5.00%)` | :arrow_down: |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `77.96% <0.00%> (-4.73%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.56% <0.00%> (-4.29%)` | :arrow_down: |
| [protocol/jsonrpc/jsonrpc\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvanNvbnJwYy9qc29ucnBjX3Byb3RvY29sLmdv) | `91.83% <0.00%> (-4.09%)` | :arrow_down: |
| ... and [183 more](https://codecov.io/gh/apache/dubbo-go/pull/1353/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0aac960...1184df2](https://codecov.io/gh/apache/dubbo-go/pull/1353?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org