You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/04 16:56:50 UTC
[GitHub] [kafka] soarez opened a new pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test
soarez opened a new pull request #10821:
URL: https://github.com/apache/kafka/pull/10821
Having the `testChrootExistsAndRootIsLocked` test in a separate `ZookeeperTestHarness` isn't enough to prevent the ACL changes to the ZK root from affecting other integration tests. So instead, let's use a dedicated znode for this test. It still works because `makeSurePersistentPathExists` uses `createRecursive`, which will recurse and act the same for the root or a given znode.
Changes:
- Use a dedicated znode for the test
- Move the test to `KafkaZkClientTest` - there is no longer a need to
keep it in a separate `ZooKeeperTestHarness`
Related: #10820
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy merged pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test
Posted by GitBox <gi...@apache.org>.
omkreddy merged pull request #10821:
URL: https://github.com/apache/kafka/pull/10821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10821:
URL: https://github.com/apache/kafka/pull/10821#issuecomment-855197777
@soarez , thanks for the quick fix. But unfortunately, the PR build still failed for "JDK 15 and Scala 2.13" build. I don't see the AclException in the log, but still failed the build. FYI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] omkreddy commented on pull request #10821: KAFKA-12892: Use dedicated root in ZK ACL test
Posted by GitBox <gi...@apache.org>.
omkreddy commented on pull request #10821:
URL: https://github.com/apache/kafka/pull/10821#issuecomment-855205284
Changes LGTM. let us re-run the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org