[jira] [Commented] (GEODE-1835) A message logged by the configure pdx command is incorrect

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15727808#comment-15727808 ] 

ASF GitHub Bot commented on GEODE-1835:
---------------------------------------

Github user ameybarve15 commented on the issue:

    https://github.com/apache/geode/pull/304
  
    Is this PR ready for commit?


> A message logged by the configure pdx command is incorrect
> ----------------------------------------------------------
>
>                 Key: GEODE-1835
>                 URL: https://issues.apache.org/jira/browse/GEODE-1835
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Barry Oglesby
>            Assignee: Amey Barve
>
> The message below is only logged when there are no members. Instead, it should be logged when there are members.
> {noformat}
> The command would only take effect on new data members joining the distributed system. It won't affect the existing data members
> {noformat}
> The condition in {{PDXCommands.configurePDX}} is:
> {noformat}
> if (CliUtil.getAllNormalMembers(CliUtil.getCacheIfExists()).isEmpty()) {
>   ird.addLine(CliStrings.CONFIGURE_PDX__NORMAL__MEMBERS__WARNING);
> }
> {noformat}
> It should test for {{!isEmpty}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)