[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9509: Reduce the size of the APIHooks, eliminating enum gap

["SolidWallOfCode (via GitHub)" <gi...@apache.org>]

SolidWallOfCode commented on code in PR #9509:
URL: https://github.com/apache/trafficserver/pull/9509#discussion_r1131487492


##########
include/ts/apidefs.h.in:
##########
@@ -481,7 +481,7 @@ typedef enum {
 
   // Putting the SSL hooks in the same enum space
   // So both sets of hooks can be set by the same Hook function
-  TS_SSL_FIRST_HOOK        = 201,
+  TS_SSL_FIRST_HOOK,

Review Comment:
   See #9480 . This is the root of the performance win from that PR, which was discussed at the last PR review. In essence the gap creates a large number of elements in the area that get checked for being cleared but are never used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org