You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/09/27 09:23:00 UTC
Review Request 38794: FALCON-1473 REST API for feed sla monitoring
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1473
https://issues.apache.org/jira/browse/FALCON-1473
Repository: falcon-git
Description
-------
This api lists all the pending feed instances in a given time range which have missed sla.
Diffs
-----
client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
common/src/main/resources/startup.properties 9db460c
docs/src/site/twiki/FalconCLI.twiki 4f72bf8
docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
src/conf/startup.properties 8f3bc35
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
Diff: https://reviews.apache.org/r/38794/diff/
Testing
-------
Unit tests added.
Tested manually by deploying.
Thanks,
Ajay Yadava
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Ajay Yadava <aj...@gmail.com>.
> On Sept. 28, 2015, 10:03 a.m., Peeyush Bishnoi wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java, line 159
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085588#file1085588line159>
> >
> > Can we use StringUtils.isEmpty.
Good idea. Fixed it.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100796
-----------------------------------------------------------
On Sept. 29, 2015, 6:10 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1473
> https://issues.apache.org/jira/browse/FALCON-1473
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This api lists all the pending feed instances in a given time range which have missed sla.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
> common/src/main/resources/startup.properties 9db460c
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
> docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
> docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
> src/conf/startup.properties 8f3bc35
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
>
> Diff: https://reviews.apache.org/r/38794/diff/
>
>
> Testing
> -------
>
> Unit tests added.
> Tested manually by deploying.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100796
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java (line 159)
<https://reviews.apache.org/r/38794/#comment158042>
Can we use StringUtils.isEmpty.
- Peeyush Bishnoi
On Sept. 27, 2015, 11:25 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2015, 11:25 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1473
> https://issues.apache.org/jira/browse/FALCON-1473
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This api lists all the pending feed instances in a given time range which have missed sla.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
> common/src/main/resources/startup.properties 9db460c
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
> docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
> docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
> src/conf/startup.properties 8f3bc35
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
>
> Diff: https://reviews.apache.org/r/38794/diff/
>
>
> Testing
> -------
>
> Unit tests added.
> Tested manually by deploying.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Ajay Yadava <aj...@gmail.com>.
> On Sept. 28, 2015, 1:08 p.m., Srikanth Sundarrajan wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 723
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085576#file1085576line723>
> >
> > Is this only sla miss for feed ? Also for a process. From the result it seems to cover all schedulable entities.
Currently, this is only for feed. We can use the same type for process also later on.
> On Sept. 28, 2015, 1:08 p.m., Srikanth Sundarrajan wrote:
> > client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java, line 33
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085580#file1085580line33>
> >
> > Should this be extending InstanceResult instead ? Will InstanceResult not suffice in this case ?
InstanceResult is very oozie instance specific and contains parameters like status, logFile, actions, wfParams etc. I can somehow fit this data in that but SchedulableEntityInstance is much cleaner and sufficient for this purpose.
> On Sept. 28, 2015, 1:08 p.m., Srikanth Sundarrajan wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 454
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085590#file1085590line454>
> >
> > Am assuming over time when an instance becomes available it would be removed from missingInstances. In this case would SLA-Miss return nothing even though the data arrived quite late ? In other words, will this feature only report missing SLA while the feed is unavailable, or will it also be able to report misses even after the data became available.
It returns only pending feed instances which have missed sla. I had documented this behavior in FeedSLA.twiki appropriately but I had missed in many other places, fixed it.
This API is useful for alerting usecases where users need to take actions e.g. to unblock pipelines. Once the data becomes available it is not so much useful from the perspective of requiring action from user but is still useful for reporting purposes. This API enables only the former usecase.
> On Sept. 28, 2015, 1:08 p.m., Srikanth Sundarrajan wrote:
> > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java, line 118
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085589#file1085589line118>
> >
> > Should the path be sla-status instead ?
Converted to sla-alert. I intend to use sla-status for reporting status of all feed instances in a given time range, which is not solved by this API.
> On Sept. 28, 2015, 1:08 p.m., Srikanth Sundarrajan wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 473
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085576#file1085576line473>
> >
> > slaMiss for a method name is a bit misleading
Converted to getFeedSLAMissPendingAlerts.
> On Sept. 28, 2015, 1:08 p.m., Srikanth Sundarrajan wrote:
> > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java, line 160
> > <https://reviews.apache.org/r/38794/diff/2/?file=1085588#file1085588line160>
> >
> > Shouldn't be accessing the FeedSLAMonitoringService instance via ServiceRegistry instead of adding a static method to the class ?
Fixed it.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100807
-----------------------------------------------------------
On Sept. 29, 2015, 6:10 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1473
> https://issues.apache.org/jira/browse/FALCON-1473
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This api lists all the pending feed instances in a given time range which have missed sla.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
> common/src/main/resources/startup.properties 9db460c
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
> docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
> docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
> src/conf/startup.properties 8f3bc35
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
>
> Diff: https://reviews.apache.org/r/38794/diff/
>
>
> Testing
> -------
>
> Unit tests added.
> Tested manually by deploying.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100807
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 473)
<https://reviews.apache.org/r/38794/#comment158047>
slaMiss for a method name is a bit misleading
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 723)
<https://reviews.apache.org/r/38794/#comment158048>
Is this only sla miss for feed ? Also for a process. From the result it seems to cover all schedulable entities.
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java (line 33)
<https://reviews.apache.org/r/38794/#comment158049>
Should this be extending InstanceResult instead ? Will InstanceResult not suffice in this case ?
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java (line 160)
<https://reviews.apache.org/r/38794/#comment158051>
Shouldn't be accessing the FeedSLAMonitoringService instance via ServiceRegistry instead of adding a static method to the class ?
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line 115)
<https://reviews.apache.org/r/38794/#comment158050>
Should the path be sla-status instead ?
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 453)
<https://reviews.apache.org/r/38794/#comment158052>
Am assuming over time when an instance becomes available it would be removed from missingInstances. In this case would SLA-Miss return nothing even though the data arrived quite late ? In other words, will this feature only report missing SLA while the feed is unavailable, or will it also be able to report misses even after the data became available.
- Srikanth Sundarrajan
On Sept. 27, 2015, 11:25 p.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2015, 11:25 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1473
> https://issues.apache.org/jira/browse/FALCON-1473
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This api lists all the pending feed instances in a given time range which have missed sla.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
> common/src/main/resources/startup.properties 9db460c
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
> docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
> docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
> src/conf/startup.properties 8f3bc35
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
>
> Diff: https://reviews.apache.org/r/38794/diff/
>
>
> Testing
> -------
>
> Unit tests added.
> Tested manually by deploying.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Ajay Yadava <aj...@gmail.com>.
> On Sept. 29, 2015, 7:29 a.m., sandeep samudrala wrote:
> > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 724
> > <https://reviews.apache.org/r/38794/diff/3/?file=1086487#file1086487line724>
> >
> > Does it makes sense to make it generic to get entity type and log "Get missing {} ..", entityType to support for process to later on?
This is just a help message, we can update it when we add support for process, it won't be a backward incompatible change.
> On Sept. 29, 2015, 7:29 a.m., sandeep samudrala wrote:
> > client/src/main/java/org/apache/falcon/client/FalconClient.java, line 200
> > <https://reviews.apache.org/r/38794/diff/3/?file=1086488#file1086488line200>
> >
> > slaAlert ? NIT. not sure.
Urls should not contain camel case, it's a bad practice, though we have it at some places.
> On Sept. 29, 2015, 7:29 a.m., sandeep samudrala wrote:
> > docs/src/site/twiki/FalconCLI.twiki, line 174
> > <https://reviews.apache.org/r/38794/diff/3/?file=1086495#file1086495line174>
> >
> > Not related to here. How are the high,Low being sent to user? It would be good to let user give sla Levels for a given entity as the user better understands the sla Level.
> >
> > If its already from the user definition ignore this comment.
> >
> > If its not, we should plan for it.
Yes, users can specify the sla through the sla tag in entity definition.
> On Sept. 29, 2015, 7:29 a.m., sandeep samudrala wrote:
> > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, line 439
> > <https://reviews.apache.org/r/38794/diff/3/?file=1086501#file1086501line439>
> >
> > The code is repeated in getFeedSLAMissPendingAlerts.
> > Can this getFeedSLAMissPendingAlerts call getFeedSLAMissPendingAlerts(feedName) for each feed?. It will be make code readible.
The common code is already extracted out in a method called getSLAStatus.
> On Sept. 29, 2015, 7:29 a.m., sandeep samudrala wrote:
> > client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java, line 57
> > <https://reviews.apache.org/r/38794/diff/3/?file=1086489#file1086489line57>
> >
> > space after '+'
Will fix while committing. I want to avoid another cycle of preparing and testing patch, just for one space.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100935
-----------------------------------------------------------
On Sept. 29, 2015, 6:10 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1473
> https://issues.apache.org/jira/browse/FALCON-1473
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This api lists all the pending feed instances in a given time range which have missed sla.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
> common/src/main/resources/startup.properties 9db460c
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
> docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
> docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
> src/conf/startup.properties 8f3bc35
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
>
> Diff: https://reviews.apache.org/r/38794/diff/
>
>
> Testing
> -------
>
> Unit tests added.
> Tested manually by deploying.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/#review100935
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/cli/FalconCLI.java (line 724)
<https://reviews.apache.org/r/38794/#comment158205>
Does it makes sense to make it generic to get entity type and log "Get missing {} ..", entityType to support for process to later on?
client/src/main/java/org/apache/falcon/client/FalconClient.java (line 200)
<https://reviews.apache.org/r/38794/#comment158206>
slaAlert ? NIT. not sure.
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java (line 57)
<https://reviews.apache.org/r/38794/#comment158207>
space after '+'
docs/src/site/twiki/FalconCLI.twiki (line 174)
<https://reviews.apache.org/r/38794/#comment158208>
Not related to here. How are the high,Low being sent to user? It would be good to let user give sla Levels for a given entity as the user better understands the sla Level.
If its already from the user definition ignore this comment.
If its not, we should plan for it.
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java (line 438)
<https://reviews.apache.org/r/38794/#comment158211>
The code is repeated in getFeedSLAMissPendingAlerts.
Can this getFeedSLAMissPendingAlerts call getFeedSLAMissPendingAlerts(feedName) for each feed?. It will be make code readible.
- sandeep samudrala
On Sept. 29, 2015, 6:10 a.m., Ajay Yadava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38794/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 6:10 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1473
> https://issues.apache.org/jira/browse/FALCON-1473
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This api lists all the pending feed instances in a given time range which have missed sla.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
> client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
> client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
> client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
> client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
> common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
> common/src/main/resources/startup.properties 9db460c
> docs/src/site/twiki/FalconCLI.twiki 4f72bf8
> docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
> docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
> prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
> prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
> src/conf/startup.properties 8f3bc35
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
>
> Diff: https://reviews.apache.org/r/38794/diff/
>
>
> Testing
> -------
>
> Unit tests added.
> Tested manually by deploying.
>
>
> Thanks,
>
> Ajay Yadava
>
>
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 6:10 a.m.)
Review request for Falcon.
Changes
-------
Addressed the review comments.
Bugs: FALCON-1473
https://issues.apache.org/jira/browse/FALCON-1473
Repository: falcon-git
Description
-------
This api lists all the pending feed instances in a given time range which have missed sla.
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
common/src/main/resources/startup.properties 9db460c
docs/src/site/twiki/FalconCLI.twiki 4f72bf8
docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
src/conf/startup.properties 8f3bc35
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
Diff: https://reviews.apache.org/r/38794/diff/
Testing
-------
Unit tests added.
Tested manually by deploying.
Thanks,
Ajay Yadava
Re: Review Request 38794: FALCON-1473 REST API for feed sla monitoring
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38794/
-----------------------------------------------------------
(Updated Sept. 27, 2015, 11:25 p.m.)
Review request for Falcon.
Bugs: FALCON-1473
https://issues.apache.org/jira/browse/FALCON-1473
Repository: falcon-git
Description
-------
This api lists all the pending feed instances in a given time range which have missed sla.
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/ResponseHelper.java a13682b
client/src/main/java/org/apache/falcon/cli/FalconCLI.java c914649
client/src/main/java/org/apache/falcon/client/FalconClient.java 981559b
client/src/main/java/org/apache/falcon/entity/v0/SchemaHelper.java 62b810c
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstance.java f5be63d
client/src/main/java/org/apache/falcon/resource/SchedulableEntityInstanceResult.java PRE-CREATION
common/src/main/java/org/apache/falcon/entity/FeedHelper.java 572923b
common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java 4f5599e
common/src/main/resources/startup.properties 9db460c
docs/src/site/twiki/FalconCLI.twiki 4f72bf8
docs/src/site/twiki/restapi/FeedSLA.twiki PRE-CREATION
docs/src/site/twiki/restapi/ResourceList.twiki ea3e3b6
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 2682257
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 3280789
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 47038e5
prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java 8bf43b8
prism/src/test/java/org/apache/falcon/service/FeedSLAMonitoringTest.java PRE-CREATION
src/conf/startup.properties 8f3bc35
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 1c0fc74
Diff: https://reviews.apache.org/r/38794/diff/
Testing
-------
Unit tests added.
Tested manually by deploying.
Thanks,
Ajay Yadava