[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3959: fix Volume migration across pools sometimes loses volume

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3959:
URL: https://github.com/apache/cloudstack/pull/3959#discussion_r413645229



##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -348,8 +348,10 @@ protected Answer copyVolumeBetweenPools(DataObject srcData, DataObject destData)
             // directly to s3
             ImageStoreEntity imageStore = (ImageStoreEntity)dataStoreMgr.getImageStoreWithFreeCapacity(destScope.getScopeId());
             if (imageStore == null || !imageStore.getProtocol().equalsIgnoreCase("nfs") && !imageStore.getProtocol().equalsIgnoreCase("cifs")) {
-                s_logger.debug("can't find a nfs (or cifs) image store to satisfy the need for a staging store");
-                return null;
+                //s_logger.debug("can't find a nfs (or cifs) image store to satisfy the need for a staging store");

Review comment:
       please remove commented code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org