You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2018/01/31 10:57:25 UTC
Review Request 65434: Ensure primary_port warning respects announcer
portmap
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/
-----------------------------------------------------------
Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
Bugs: AURORA-1233
https://issues.apache.org/jira/browse/AURORA-1233
Repository: aurora
Description
-------
This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
Diffs
-----
src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
Diff: https://reviews.apache.org/r/65434/diff/1/
Testing
-------
./build-support/jenkins/build.sh
Thanks,
Stephan Erb
Re: Review Request 65434: Ensure primary_port warning respects
announcer portmap
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196564
-----------------------------------------------------------
Ship it!
Master (787ccfe) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 31, 2018, 10:57 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65434/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 10:57 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1233
> https://issues.apache.org/jira/browse/AURORA-1233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
> src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
>
>
> Diff: https://reviews.apache.org/r/65434/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 65434: Ensure primary_port warning respects
announcer portmap
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196563
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Jan. 31, 2018, 11:57 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65434/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 11:57 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1233
> https://issues.apache.org/jira/browse/AURORA-1233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
> src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
>
>
> Diff: https://reviews.apache.org/r/65434/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 65434: Ensure primary_port warning respects
announcer portmap
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196568
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Jan. 31, 2018, 2:57 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65434/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 2:57 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1233
> https://issues.apache.org/jira/browse/AURORA-1233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
> src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
>
>
> Diff: https://reviews.apache.org/r/65434/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 65434: Ensure primary_port warning respects
announcer portmap
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196561
-----------------------------------------------------------
src/main/python/apache/aurora/client/config.py
Lines 47-49 (original), 49-50 (patched)
<https://reviews.apache.org/r/65434/#comment276262>
Note to reviewers: `config.raw().has_announce()` is already checked above so I could simplify the condition here. This is just a refactoring and independent of the behaviour change of this patch.
- Stephan Erb
On Jan. 31, 2018, 11:57 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65434/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 11:57 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1233
> https://issues.apache.org/jira/browse/AURORA-1233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
> src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
>
>
> Diff: https://reviews.apache.org/r/65434/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 65434: Ensure primary_port warning respects
announcer portmap
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196603
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On Jan. 31, 2018, 10:57 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65434/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 10:57 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1233
> https://issues.apache.org/jira/browse/AURORA-1233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
> src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
>
>
> Diff: https://reviews.apache.org/r/65434/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 65434: Ensure primary_port warning respects
announcer portmap
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65434/#review196562
-----------------------------------------------------------
Master (787ccfe) is red with this patch.
./build-support/jenkins/build.sh
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
--------------- Captured log call ----------------
health_checker.py 167 INFO INFO] Reached consecutive success limit.
health_checker.py 143 WARNING WARN] Health check failure: failure-2
health_checker.py 184 WARNING WARN] Ignoring failure of attempt: 2
health_checker.py 143 WARNING WARN] Health check failure: failure-3
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
2 failed, 798 passed, 6 skipped in 246.38 seconds
FAILURE
Waiting for background workers to finish.
11:12:38 04:43 [complete]
FAILURE
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 31, 2018, 10:57 a.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65434/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2018, 10:57 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1233
> https://issues.apache.org/jira/browse/AURORA-1233
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This eliminates false-positive warnings in the client: It used to complain about unbound primary ports if those where bound via the portmap.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/config.py adc8db0290d80a0ebfed983f6518d063f355d81f
> src/test/python/apache/aurora/client/test_config.py 3d5289adcb2d53506644604380797ff64227fecd
>
>
> Diff: https://reviews.apache.org/r/65434/diff/1/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>