You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/03/31 10:24:40 UTC
[GitHub] incubator-weex pull request #206: *[ios] refactor gradient color
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/206
*[ios] refactor gradient color
I make gradient color function as utility to use
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex 0.12-dev-gradient-color
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #206
----
commit 3b0d04998a3d16642d6deef070b32bc701a6ea59
Author: acton393 <zh...@gmail.com>
Date: 2017-03-31T10:18:45Z
* [ios] refactor gradient-color method
commit 9553bd41d62f2ff02ef3756d3a9547345514025b
Author: acton393 <zh...@gmail.com>
Date: 2017-03-31T10:20:48Z
* [ios] add default value
commit a44a946f830ed7e7ef0628f9073d8be77e0dd788
Author: acton393 <zh...@gmail.com>
Date: 2017-03-31T10:22:51Z
* [ios] fix box shadow shadowColor get method circularly called
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #206: *[ios] refactor gradient color
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/206#discussion_r109192198
--- Diff: ios/sdk/WeexSDK/Sources/Utility/WXUtility.h ---
@@ -357,6 +357,33 @@ CGRect WXPixelFrameResize(CGRect value) DEPRECATED_MSG_ATTRIBUTE("Use WXPixelSca
CGPoint WXPixelPointResize(CGPoint value) DEPRECATED_MSG_ATTRIBUTE("Use WXPixelScale Instead");
+ (UIFont * _Nullable )fontWithSize:(CGFloat)size textWeight:(CGFloat)textWeight textStyle:(WXTextStyle)textStyle fontFamily:(NSString * _Nullable)fontFamily DEPRECATED_MSG_ATTRIBUTE("Use +[WXUtility fontWithSize:textWeight:textStyle:fontFamily:scaleFactor:]");
+
--- End diff --
WXUtility is too heavy now, maybe we should take another place
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #206: *[ios] refactor gradient color
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/206#discussion_r109132119
--- Diff: ios/sdk/WeexSDK/Sources/Utility/WXBoxShadow.m ---
@@ -11,10 +11,11 @@
#import "WXUtility.h"
--- End diff --
Maybe you should concentrate more on this file change @kfeagle
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #206: *[ios] refactor gradient color
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/206
@acton393 Please resolve conflicts first, @boboning Please have a review on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #206: *[ios] refactor gradient color
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #206: *[ios] refactor gradient color
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/206#discussion_r109304999
--- Diff: ios/sdk/WeexSDK/Sources/Utility/WXUtility.h ---
@@ -357,6 +357,33 @@ CGRect WXPixelFrameResize(CGRect value) DEPRECATED_MSG_ATTRIBUTE("Use WXPixelSca
CGPoint WXPixelPointResize(CGPoint value) DEPRECATED_MSG_ATTRIBUTE("Use WXPixelScale Instead");
+ (UIFont * _Nullable )fontWithSize:(CGFloat)size textWeight:(CGFloat)textWeight textStyle:(WXTextStyle)textStyle fontFamily:(NSString * _Nullable)fontFamily DEPRECATED_MSG_ATTRIBUTE("Use +[WXUtility fontWithSize:textWeight:textStyle:fontFamily:scaleFactor:]");
+
--- End diff --
sure, it has become too complicated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---