[GitHub] honganan commented on a change in pull request #1913: fix bug #1912, the usage of ignore() problem

[GitBox <gi...@apache.org>]

honganan commented on a change in pull request #1913: fix bug #1912, the usage of ignore() problem
URL: https://github.com/apache/incubator-skywalking/pull/1913#discussion_r234143873
 
 

 ##########
 File path: apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
 ##########
 @@ -75,12 +76,14 @@ public static void premain(String agentArgs, Instrumentation instrumentation) th
 
         new AgentBuilder.Default(byteBuddy)
             .ignore(nameStartsWith("net.bytebuddy."))
-            .ignore(nameStartsWith("org.slf4j."))
-            .ignore(nameStartsWith("org.apache.logging."))
-            .ignore(nameStartsWith("org.groovy."))
-            .ignore(nameContains("javassist"))
-            .ignore(nameContains(".asm."))
-            .ignore(allSkyWalkingAgentExcludeToolkit())
+                .or(nameStartsWith("org.slf4j."))
 
 Review comment:
   God，I have made a mistake in using of bracket, sorry, I will check this carefully and send a PR again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services