[jira] [Commented] (OFBIZ-13676) MacroMenuRenderer: pass the macro parameters as data

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-13676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18127683#comment-18127683 ] 

ASF subversion and git services commented on OFBIZ-13676:
---------------------------------------------------------

Commit fb6b2939cd7afbbc15ab83d92de9a0d9e2409f6c in ofbiz-framework's branch refs/heads/trunk from Mridul Pathak
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=fb6b2939cd ]

Improved: MacroMenuRenderer passes the macro parameters as data (OFBIZ-13676)

MacroMenuRenderer built the text of each macro call from a parameter map and compiled it, and kept its own environments and template compilation. It now passes the parameters to FtlWriter as data, with the parameterList of renderLink as a list of name and value maps instead of a hash literal built as text. The macro signatures and the output are unchanged, except that the parameter names and values of hidden-form and layered-modal links are no longer interpreted as FreeMarker, which used to fail to render, or evaluate, a link whose parameter name or value contained a quote, a backslash or an interpolation.


> MacroMenuRenderer: pass the macro parameters as data
> ----------------------------------------------------
>
>                 Key: OFBIZ-13676
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13676
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: framework/widget
>    Affects Versions: Upcoming Branch
>            Reporter: Mridul Pathak
>            Assignee: Mridul Pathak
>            Priority: Minor
>
> {{MacroMenuRenderer}} builds the text of each macro call from a parameter map and compiles it. Run the calls through the shared {{FtlWriter}} helper with the parameter map as data, pass the {{parameterList}} of {{renderLink}} as a real list of name/value maps instead of a hash literal, and use a weak map for the per-writer environments. The menu macro signatures stay as they are.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)