You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/27 09:18:30 UTC

[GitHub] [superset] kgabryje commented on a change in pull request #12789: fix(explore): pass partitionColumn when creating new adhoc filter

kgabryje commented on a change in pull request #12789:
URL: https://github.com/apache/superset/pull/12789#discussion_r565145732



##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl.jsx
##########
@@ -128,14 +128,14 @@ class AdhocFilterControl extends React.Component {
                 partitions.cols &&
                 Object.keys(partitions.cols).length === 1
               ) {
-                const partitionColumn = partitions.cols[0];
+                this.setState({ partitionColumn: partitions.cols[0] });

Review comment:
       I think we should include `partitionColumn` in state declaration in constructor




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org