[jira] [Created] (YARN-8362) Number of remaining retries are updated twice after a container failure in NM

["Chandni Singh (JIRA)" <ji...@apache.org>]

Chandni Singh created YARN-8362:
-----------------------------------

             Summary: Number of remaining retries are updated twice after a container failure in NM 
                 Key: YARN-8362
                 URL: https://issues.apache.org/jira/browse/YARN-8362
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Chandni Singh
            Assignee: Chandni Singh
             Fix For: 3.2.0, 3.1.1


The {{shouldRetry(int errorCode)}} in {{ContainerImpl}} with YARN-5015 also updated some fields in retry context- remaining retries, restart times.

This method is directly called from outside the ContainerImpl class as well- {{ContainerLaunch.setContainerCompletedStatus}}. This causes following problems:
 # remainingRetries are updated more than once after a failure. if {{maxRetries = 1}}, then a retry will not be triggered because of multiple calls to {{shouldRetry(int errorCode).}}
 # Writes to {{retryContext}} should be protected and called when the write lock is held.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org