[jira] [Commented] (LUCENE-3729) Allow using FST to hold terms data in DocValues.BYTES_*_SORTED

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396032#comment-13396032 ] 

Michael McCandless commented on LUCENE-3729:
--------------------------------------------

Very cool!

Why did you need a custom subclass of FSTEnum (instead of
BytesRefFSTEnum)?  Is it for getOutput?  Couldn't you
getCurrent().output instead?

We could probably make a static Util.getCeil (like Util.get, but
finds ceiling term if there is no exact match) ... would likely be
faster than re-using an FSTEnum ... but sorta hairy to write.

I'm curious how DV sort perf compares ... hopefully it's little loss
(going on my previous tests here...).

Awesome to fix seekCeil to return enum result ... maybe factor out the
same enum from TermsEnum so we can share it?  And you can remove the
two TODOs from FSTEnum.java...

Can ToFSTBytesRefConsumer be moved to FSTSortedBytesImpl.java?

                
> Allow using FST to hold terms data in DocValues.BYTES_*_SORTED
> --------------------------------------------------------------
>
>                 Key: LUCENE-3729
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3729
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>              Labels: gsoc2012, lucene-gsoc-11
>         Attachments: LUCENE-3729.patch, LUCENE-3729.patch, LUCENE-3729.patch, LUCENE-3729.patch, LUCENE-3729.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org