[GitHub] [mynewt-core] utzig commented on a change in pull request #2130: Remove restriction in syscfg to define bitbang RX pin

[GitBox <gi...@apache.org>]

utzig commented on a change in pull request #2130: Remove restriction in syscfg to define bitbang RX pin
URL: https://github.com/apache/mynewt-core/pull/2130#discussion_r357121617
 
 

 ##########
 File path: hw/mcu/stm/stm32l1xx/src/ext/Drivers/STM32L1xx_HAL_Driver/Src/stm32l1xx_hal_spi.c
 ##########
 @@ -171,6 +171,7 @@ static HAL_StatusTypeDef SPI_WaitOnFlagUntilTimeout(struct __SPI_HandleTypeDef *
   * @{
   */
 
+#if 0 /* Fully defined in stm32l1xx_hal_spi_ex.c */
 
 Review comment:
   Apart from not being related with the PR, this is not OK!
   
   1) Don't change SDK code, unless there is no way of handling the issue elsewhere
   2) Don't add `#if 0`. If something should not be here, delete it (in this case maybe it would make some sense though).
   3) This is handled already in `hw/mcu/stm/stm32_common/src/stm32_driver_mod_spi.c`, so maybe what you may want is to change the `#if defined(STM32L152xC)` to `#if MYNEWT_VAL(MCU_STM32L1)` in case you are using some MCU that is not a L152xC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services