You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by sagelywizard <gi...@git.apache.org> on 2017/03/10 02:27:22 UTC

[GitHub] couchdb-couch-mrview pull request #68: Fix undef error on empty list functio...

GitHub user sagelywizard opened a pull request:

    https://github.com/apache/couchdb-couch-mrview/pull/68

    Fix undef error on empty list function response

    Prior to this commit, if a list function did not return any data or
    returned an error, it would return a #lacc{} record from list_cb/2
    rather than a valid #mochiweb_response{} record. This would cause chttpd
    to crash. This commit fixes this bug by always returning a valid
    record.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/couchdb-couch-mrview undef-lacc-list-function

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-mrview/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
    
----
commit 56616fad9b0621b6606e4b521a2ec4b8342877aa
Author: Benjamin Bastian <be...@gmail.com>
Date:   2017-03-10T02:20:25Z

    Fix undef error on empty list function response
    
    Prior to this commit, if a list function did not return any data or
    returned an error, it would return a #lacc{} record from list_cb/2
    rather than a valid #mochiweb_response{} record. This would cause chttpd
    to crash. This commit fixes this bug by always returning a valid
    record.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-mrview pull request #68: Fix undef error on empty list functio...

Posted by sagelywizard <gi...@git.apache.org>.
Github user sagelywizard closed the pull request at:

    https://github.com/apache/couchdb-couch-mrview/pull/68


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-mrview issue #68: Fix undef error on empty list function respo...

Posted by sagelywizard <gi...@git.apache.org>.
Github user sagelywizard commented on the issue:

    https://github.com/apache/couchdb-couch-mrview/pull/68
  
    Closing PR to reopen from `cloudant` fork, as @jaydoane added some tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---