[jira] [Commented] (LEGAL-156) Can we accept pull requests from github ?

["Mark Thomas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LEGAL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554864#comment-13554864 ] 

Mark Thomas commented on LEGAL-156:
-----------------------------------

Short answer: Of course you can.

Long answer: Any contribution - in any form (patch to the mailing list, blog post, JIRA attchment, git pull request, Bugzilla attachment, scrawled on the back of a napkin) - may be included as long as two conditions are met:

1. As per section 5 of AL2 the person providing the patch does not explicitly state that the patch provided is not licensed under ALv2

2. The project's PMC is happy that the person providing the contribution has the necessary rights to do so. This should be a very low bar (although I have seen lots of projects making artificially and unnecessarily high). Apache Tomcat works on the basis that unless there is a clear indication otherwise (e.g. a copyright header on the patch or a different license on the patch) then the provider does have the right to submit the patch. I can think of one issue in 10 years where there was a problem in this area and that was actually with code that came in to the ASF via another ASF project that Tomcat re-used and it took a couple of e-mails to fix. Worst case it would have had to have been re-written.
                
> Can we accept pull requests from github ?
> -----------------------------------------
>
>                 Key: LEGAL-156
>                 URL: https://issues.apache.org/jira/browse/LEGAL-156
>             Project: Legal Discuss
>          Issue Type: Question
>            Reporter: Kristian Rosenvold
>
> In maven, we generally require that all external submissions have JIRA issues. With svn we would normally have patches attached to the jira issue, which would link a submission to the submitter.
> With pull requests coming in from github, we receive a "submission" that is tagged with author name and email and an external reference to the diff (a link to the commit on github). This pull request is sent to ASF mailing lists and would IMO serve as a record of submission. Given that the author information in the commit seems valid, can we accept such a pull request directly ? (to this moment we still require that authors add patches to jira as well)
> (It would look to me like the only thing missing is that we have the process picking up the pull requests actually attach the diff to the mail too, but heck IANAL).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org