You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2014/06/19 04:50:36 UTC
git commit: Upgrade to OkHttp 1.6.0
Repository: jclouds
Updated Branches:
refs/heads/master 1982626cd -> ad56db2a4
Upgrade to OkHttp 1.6.0
This upgrades both drivers/okhttp and mockwebserver. Changelog:
https://github.com/square/okhttp/blob/master/CHANGELOG.md
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
Branch: refs/heads/master
Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
Parents: 1982626
Author: Andrew Gaul <ga...@apache.org>
Authored: Wed Jun 18 19:41:46 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Wed Jun 18 19:49:50 2014 -0700
----------------------------------------------------------------------
project/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
----------------------------------------------------------------------
diff --git a/project/pom.xml b/project/pom.xml
index 2d3b651..4b259d0 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -201,7 +201,7 @@
<jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
<test.ssh.keyfile />
<sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
- <okhttp.version>1.3.0</okhttp.version>
+ <okhttp.version>1.6.0</okhttp.version>
<surefire.version>2.17</surefire.version>
</properties>
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Ignasi Barrera <na...@apache.org>.
Thanks for the feedback Andrew.
Those test don't use the PATCH method, so we can assume the version
bump is not breaking anything.
Regarding the 2.0.0-RC2 version questions, it was just me being
curious :) I'll open an improvement to update it!
Thanks!
I.
On 19 June 2014 14:25, Andrew Gaul <ga...@apache.org> wrote:
> On Thu, Jun 19, 2014 at 09:43:49AM +0200, Ignasi Barrera wrote:
>> Thanks for keeping this up to date Andrew! Just a couple considerations:
>>
>> * The "okhttp.version" property is also used in the OkHttp driver. Could
>> you run the openstack-marconi live tests (or the rackspace-cloudqueues
>> ones)? Marconi uses the OkHttp driver by default to be able to send PATCH
>> requests. Just want to make sure the version bump is not breaking anything.
>
> I see the same failed tests before and after upgrading with:
>
> mvn integration-test -pl rackspace-cloudqueues-us -Plive \
> -Dtest.rackspace-cloudqueues-us.identity="${JCLOUDS_IDENTITY}" \
> -Dtest.rackspace-cloudqueues-us.credential="${JCLOUDS_CREDENTIAL}"
>
> Failed tests:
> CloudQueuesUSQueueApiLiveTest>QueueApiLiveTest.listZeroPagesOfQueues:47 expected [true] but found [false]
> CloudQueuesUSMessageApiLiveTest>MessageApiLiveTest.streamZeroPagesOfMessages:64 expected [true] but found [false]
>
> All tests succeed against 1.7.x; Everett can you investigate these failures?
>
>> * Have you tried (or could you try, if not) upgrading to the latest
>> 2.0.0-RC2?
>
> Sorry, I have not tested this and my limited experience with OkHttp does
> not give me confidence in upgrading to a release candidate. This commit
> addresses an OutOfMemoryError seen with large payloads in Glacier tests
> and a pending pull request removes a stale dependency on an older
> mockwebserver artifact.
>
>> Thanks!
>>
>> I.
>> El 19/06/2014 04:50, <ga...@apache.org> escribió:
>>
>> > Repository: jclouds
>> > Updated Branches:
>> > refs/heads/master 1982626cd -> ad56db2a4
>> >
>> >
>> > Upgrade to OkHttp 1.6.0
>> >
>> > This upgrades both drivers/okhttp and mockwebserver. Changelog:
>> >
>> > https://github.com/square/okhttp/blob/master/CHANGELOG.md
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
>> > Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
>> > Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
>> > Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
>> >
>> > Branch: refs/heads/master
>> > Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
>> > Parents: 1982626
>> > Author: Andrew Gaul <ga...@apache.org>
>> > Authored: Wed Jun 18 19:41:46 2014 -0700
>> > Committer: Andrew Gaul <ga...@apache.org>
>> > Committed: Wed Jun 18 19:49:50 2014 -0700
>> >
>> > ----------------------------------------------------------------------
>> > project/pom.xml | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > ----------------------------------------------------------------------
>> >
>> >
>> >
>> > http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
>> > ----------------------------------------------------------------------
>> > diff --git a/project/pom.xml b/project/pom.xml
>> > index 2d3b651..4b259d0 100644
>> > --- a/project/pom.xml
>> > +++ b/project/pom.xml
>> > @@ -201,7 +201,7 @@
>> >
>> > <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
>> > <test.ssh.keyfile />
>> >
>> > <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
>> > - <okhttp.version>1.3.0</okhttp.version>
>> > + <okhttp.version>1.6.0</okhttp.version>
>> > <surefire.version>2.17</surefire.version>
>> > </properties>
>> >
>> >
>> >
>
> --
> Andrew Gaul
> http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Gaul <ga...@apache.org>.
On Thu, Jun 19, 2014 at 09:43:49AM +0200, Ignasi Barrera wrote:
> Thanks for keeping this up to date Andrew! Just a couple considerations:
>
> * The "okhttp.version" property is also used in the OkHttp driver. Could
> you run the openstack-marconi live tests (or the rackspace-cloudqueues
> ones)? Marconi uses the OkHttp driver by default to be able to send PATCH
> requests. Just want to make sure the version bump is not breaking anything.
I see the same failed tests before and after upgrading with:
mvn integration-test -pl rackspace-cloudqueues-us -Plive \
-Dtest.rackspace-cloudqueues-us.identity="${JCLOUDS_IDENTITY}" \
-Dtest.rackspace-cloudqueues-us.credential="${JCLOUDS_CREDENTIAL}"
Failed tests:
CloudQueuesUSQueueApiLiveTest>QueueApiLiveTest.listZeroPagesOfQueues:47 expected [true] but found [false]
CloudQueuesUSMessageApiLiveTest>MessageApiLiveTest.streamZeroPagesOfMessages:64 expected [true] but found [false]
All tests succeed against 1.7.x; Everett can you investigate these failures?
> * Have you tried (or could you try, if not) upgrading to the latest
> 2.0.0-RC2?
Sorry, I have not tested this and my limited experience with OkHttp does
not give me confidence in upgrading to a release candidate. This commit
addresses an OutOfMemoryError seen with large payloads in Glacier tests
and a pending pull request removes a stale dependency on an older
mockwebserver artifact.
> Thanks!
>
> I.
> El 19/06/2014 04:50, <ga...@apache.org> escribió:
>
> > Repository: jclouds
> > Updated Branches:
> > refs/heads/master 1982626cd -> ad56db2a4
> >
> >
> > Upgrade to OkHttp 1.6.0
> >
> > This upgrades both drivers/okhttp and mockwebserver. Changelog:
> >
> > https://github.com/square/okhttp/blob/master/CHANGELOG.md
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> > Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> > Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
> >
> > Branch: refs/heads/master
> > Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> > Parents: 1982626
> > Author: Andrew Gaul <ga...@apache.org>
> > Authored: Wed Jun 18 19:41:46 2014 -0700
> > Committer: Andrew Gaul <ga...@apache.org>
> > Committed: Wed Jun 18 19:49:50 2014 -0700
> >
> > ----------------------------------------------------------------------
> > project/pom.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> > http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/project/pom.xml b/project/pom.xml
> > index 2d3b651..4b259d0 100644
> > --- a/project/pom.xml
> > +++ b/project/pom.xml
> > @@ -201,7 +201,7 @@
> >
> > <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
> > <test.ssh.keyfile />
> >
> > <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
> > - <okhttp.version>1.3.0</okhttp.version>
> > + <okhttp.version>1.6.0</okhttp.version>
> > <surefire.version>2.17</surefire.version>
> > </properties>
> >
> >
> >
--
Andrew Gaul
http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Ignasi Barrera <na...@apache.org>.
Thanks for keeping this up to date Andrew! Just a couple considerations:
* The "okhttp.version" property is also used in the OkHttp driver. Could
you run the openstack-marconi live tests (or the rackspace-cloudqueues
ones)? Marconi uses the OkHttp driver by default to be able to send PATCH
requests. Just want to make sure the version bump is not breaking anything.
* Have you tried (or could you try, if not) upgrading to the latest
2.0.0-RC2?
Thanks!
I.
El 19/06/2014 04:50, <ga...@apache.org> escribió:
> Repository: jclouds
> Updated Branches:
> refs/heads/master 1982626cd -> ad56db2a4
>
>
> Upgrade to OkHttp 1.6.0
>
> This upgrades both drivers/okhttp and mockwebserver. Changelog:
>
> https://github.com/square/okhttp/blob/master/CHANGELOG.md
>
>
> Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
>
> Branch: refs/heads/master
> Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> Parents: 1982626
> Author: Andrew Gaul <ga...@apache.org>
> Authored: Wed Jun 18 19:41:46 2014 -0700
> Committer: Andrew Gaul <ga...@apache.org>
> Committed: Wed Jun 18 19:49:50 2014 -0700
>
> ----------------------------------------------------------------------
> project/pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
> ----------------------------------------------------------------------
> diff --git a/project/pom.xml b/project/pom.xml
> index 2d3b651..4b259d0 100644
> --- a/project/pom.xml
> +++ b/project/pom.xml
> @@ -201,7 +201,7 @@
>
> <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
> <test.ssh.keyfile />
>
> <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
> - <okhttp.version>1.3.0</okhttp.version>
> + <okhttp.version>1.6.0</okhttp.version>
> <surefire.version>2.17</surefire.version>
> </properties>
>
>
>
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Ignasi Barrera <na...@apache.org>.
Unfortunately, regular branch builds fail too often, and with false
negatives, to trust them.
Nexus transient issues apart (is there an INFRA ticket?), this is one of
the side effects of having so many repos. Downstream builds need the main
repo snapshots properly populated and most failures are due to those builds
running "too early", before those are ready. Most failures are from the
downstream repos and caused by this. If we can workaround it in some way,
I' m sure we'll considerably reduce the noise and false negatives.
That said, having those builds, personally, gives me the confidence for the
commit-then-review practice.
In this case I'm pretty sure the scope of the version bump wasn't known (I
personally don't remember most of the details in the blobstore providers)
and understand that the use of the OkHttp can be unknown for some (fair
enough!). Fortunately we have the CI builds (when fixed) and individuals
reviewing the commit notificarions, and for me that's enough.
Commit-then-review will always have the counterpart that someone else could
have something to say to the change, that will always be there, but that is
part of the "then-review" part. This exactly what we did here by replying
to the commit notification mentioning some additional checks.
IMO the process we have works and I personally trust every committer. I am
quite comfortable with it and believe that the current process and tools
give us enough confidence for the commit-then-review practice.
El 19/06/2014 22:54, "Jeremy Daggett" <je...@rackspace.com>
escribió:
> FWIWŠ Another data point for the discussion here.
>
> Over the past couple of weeks, I started working on a PR submitted for the
> OpenStack Glance v2
> API (thanks @sallum):
> https://github.com/jclouds/jclouds-labs-openstack/pull/77
>
> I updated to 2.0.0-RC2 as soon as it was released to the masses. My intent
> is to use the 2.0.0 version by
> default as soon as it is officially released.
>
> /jd
>
> On 6/19/14, 12:53 PM, "Andrew Gaul" <ga...@apache.org> wrote:
>
> >Everyone will have their own opinion on this, but raising the bar with
> >consensus tends to lower the velocity of development and quantity of
> >contributions. Gaining consensus for a dependency upgrade is far below
> >my bar for notifying others or desiring to be notified. If a given
> >commit causes a regression, we can always revert it.
> >
> >On Thu, Jun 19, 2014 at 07:06:42PM +0000, Everett Toews wrote:
> >> Agreed that commit-then-review is fine for smaller changes but this
> >>doesn¹t fall into that category.
> >>
> >> The okhttp.version affects downstream modules (e.g. openstack-marconi)
> >>and changing that version could break those downstream modules. I don¹t
> >>classify that as a small change.
> >>
> >> Also, committing directly to the ASF git repo circumvents the CI jobs
> >>when a pull request is made in GitHub. Those jobs could catch any
> >>obvious problems and provide a layer of protection from breaking the
> >>build.
> >>
> >> I completely understand the desire to move fast on some of this stuff.
> >>It would be nice if you could give those of us who are maintaining
> >>downstream modules a heads up on IRC or via email.
> >>
> >> Regards,
> >> Everett
> >>
> >>
> >> On Jun 19, 2014, at 12:30 PM, Andrew Gaul <ga...@apache.org> wrote:
> >>
> >> > Committers are free to use commit-then-review or review-then-commit.
> >>I
> >> > often use the former for smaller changes.
> >> >
> >> > On Thu, Jun 19, 2014 at 02:48:24PM +0000, Everett Toews wrote:
> >> >> Where¹s the pull request for this?
> >> >>
> >> >> Everett
> >> >>
> >> >>
> >> >> On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
> >> >>
> >> >>> Repository: jclouds
> >> >>> Updated Branches:
> >> >>> refs/heads/master 1982626cd -> ad56db2a4
> >> >>>
> >> >>>
> >> >>> Upgrade to OkHttp 1.6.0
> >> >>>
> >> >>> This upgrades both drivers/okhttp and mockwebserver. Changelog:
> >> >>>
> >> >>> https://github.com/square/okhttp/blob/master/CHANGELOG.md
> >> >>>
> >> >>>
> >> >>> Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> >> >>> Commit:
> >>http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> >> >>> Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> >> >>> Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
> >> >>>
> >> >>> Branch: refs/heads/master
> >> >>> Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> >> >>> Parents: 1982626
> >> >>> Author: Andrew Gaul <ga...@apache.org>
> >> >>> Authored: Wed Jun 18 19:41:46 2014 -0700
> >> >>> Committer: Andrew Gaul <ga...@apache.org>
> >> >>> Committed: Wed Jun 18 19:49:50 2014 -0700
> >> >>>
> >> >>>
> >>----------------------------------------------------------------------
> >> >>> project/pom.xml | 2 +-
> >> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >>>
> >>----------------------------------------------------------------------
> >> >>>
> >> >>>
> >> >>>
> >>http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom
> .
> >>xml
> >> >>>
> >>----------------------------------------------------------------------
> >> >>> diff --git a/project/pom.xml b/project/pom.xml
> >> >>> index 2d3b651..4b259d0 100644
> >> >>> --- a/project/pom.xml
> >> >>> +++ b/project/pom.xml
> >> >>> @@ -201,7 +201,7 @@
> >> >>>
> >><jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jc
> >>louds.test.listener>
> >> >>> <test.ssh.keyfile />
> >> >>>
> >><sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAss
> >>emblyDescriptor>
> >> >>> - <okhttp.version>1.3.0</okhttp.version>
> >> >>> + <okhttp.version>1.6.0</okhttp.version>
> >> >>> <surefire.version>2.17</surefire.version>
> >> >>> </properties>
> >> >>>
> >> >>>
> >> >
> >> > --
> >> > Andrew Gaul
> >> > http://gaul.org/
> >
> >--
> >Andrew Gaul
> >http://gaul.org/
>
>
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Phillips <ap...@qrmedia.com>.
> I am struggling to stay on top on my GSoC review queue; can someone
> else investigate these racy tests and flaky infrastructure?
I recall seeing a test PR from abayer with comments coming from the
Apache Jenkins (I think). Unfortunately, I'm not sure that would have
helped in this case since the culprit seems to be ASF Nexus rather
than CloudBees or BuildHive, but still...
Any news on that, by the way, abayer? ;-)
ap
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Gaul <ga...@apache.org>.
On Thu, Jun 19, 2014 at 10:40:45PM +0200, Andrew Phillips wrote:
> >>Also, committing directly to the ASF git repo circumvents the CI
> >>jobs when a pull request is made in GitHub. Those jobs could
> >>catch any obvious problems and provide a layer of protection
> >>from breaking the build.
>
> What's unfortunate in this case is that we *also* have CI
> infrastructure that is supposed to flag up changes by commits such
> as this, which would allow us to quickly revert them if necessary.
>
> It looks like the Apache Nexus server has been throwing 503s all
> over our builds [1] :-( I hope we'll be back to normal soon.
The large amount of noise from Cloudbees and BuildHive has caused me to
ignore their results and do most of my testing locally. I am struggling
to stay on top on my GSoC review queue; can someone else investigate
these racy tests and flaky infrastructure?
--
Andrew Gaul
http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Phillips <ap...@qrmedia.com>.
>> Also, committing directly to the ASF git repo circumvents the CI
>> jobs when a pull request is made in GitHub. Those jobs could catch
>> any obvious problems and provide a layer of protection from
>> breaking the build.
What's unfortunate in this case is that we *also* have CI
infrastructure that is supposed to flag up changes by commits such as
this, which would allow us to quickly revert them if necessary.
It looks like the Apache Nexus server has been throwing 503s all over
our builds [1] :-( I hope we'll be back to normal soon.
ap
[1] https://jclouds.ci.cloudbees.com/job/jclouds/2637/console
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Jeremy Daggett <je...@RACKSPACE.COM>.
FWIWŠ Another data point for the discussion here.
Over the past couple of weeks, I started working on a PR submitted for the
OpenStack Glance v2
API (thanks @sallum):
https://github.com/jclouds/jclouds-labs-openstack/pull/77
I updated to 2.0.0-RC2 as soon as it was released to the masses. My intent
is to use the 2.0.0 version by
default as soon as it is officially released.
/jd
On 6/19/14, 12:53 PM, "Andrew Gaul" <ga...@apache.org> wrote:
>Everyone will have their own opinion on this, but raising the bar with
>consensus tends to lower the velocity of development and quantity of
>contributions. Gaining consensus for a dependency upgrade is far below
>my bar for notifying others or desiring to be notified. If a given
>commit causes a regression, we can always revert it.
>
>On Thu, Jun 19, 2014 at 07:06:42PM +0000, Everett Toews wrote:
>> Agreed that commit-then-review is fine for smaller changes but this
>>doesn¹t fall into that category.
>>
>> The okhttp.version affects downstream modules (e.g. openstack-marconi)
>>and changing that version could break those downstream modules. I don¹t
>>classify that as a small change.
>>
>> Also, committing directly to the ASF git repo circumvents the CI jobs
>>when a pull request is made in GitHub. Those jobs could catch any
>>obvious problems and provide a layer of protection from breaking the
>>build.
>>
>> I completely understand the desire to move fast on some of this stuff.
>>It would be nice if you could give those of us who are maintaining
>>downstream modules a heads up on IRC or via email.
>>
>> Regards,
>> Everett
>>
>>
>> On Jun 19, 2014, at 12:30 PM, Andrew Gaul <ga...@apache.org> wrote:
>>
>> > Committers are free to use commit-then-review or review-then-commit.
>>I
>> > often use the former for smaller changes.
>> >
>> > On Thu, Jun 19, 2014 at 02:48:24PM +0000, Everett Toews wrote:
>> >> Where¹s the pull request for this?
>> >>
>> >> Everett
>> >>
>> >>
>> >> On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
>> >>
>> >>> Repository: jclouds
>> >>> Updated Branches:
>> >>> refs/heads/master 1982626cd -> ad56db2a4
>> >>>
>> >>>
>> >>> Upgrade to OkHttp 1.6.0
>> >>>
>> >>> This upgrades both drivers/okhttp and mockwebserver. Changelog:
>> >>>
>> >>> https://github.com/square/okhttp/blob/master/CHANGELOG.md
>> >>>
>> >>>
>> >>> Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
>> >>> Commit:
>>http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
>> >>> Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
>> >>> Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
>> >>>
>> >>> Branch: refs/heads/master
>> >>> Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
>> >>> Parents: 1982626
>> >>> Author: Andrew Gaul <ga...@apache.org>
>> >>> Authored: Wed Jun 18 19:41:46 2014 -0700
>> >>> Committer: Andrew Gaul <ga...@apache.org>
>> >>> Committed: Wed Jun 18 19:49:50 2014 -0700
>> >>>
>> >>>
>>----------------------------------------------------------------------
>> >>> project/pom.xml | 2 +-
>> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>>
>>----------------------------------------------------------------------
>> >>>
>> >>>
>> >>>
>>http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.
>>xml
>> >>>
>>----------------------------------------------------------------------
>> >>> diff --git a/project/pom.xml b/project/pom.xml
>> >>> index 2d3b651..4b259d0 100644
>> >>> --- a/project/pom.xml
>> >>> +++ b/project/pom.xml
>> >>> @@ -201,7 +201,7 @@
>> >>>
>><jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jc
>>louds.test.listener>
>> >>> <test.ssh.keyfile />
>> >>>
>><sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAss
>>emblyDescriptor>
>> >>> - <okhttp.version>1.3.0</okhttp.version>
>> >>> + <okhttp.version>1.6.0</okhttp.version>
>> >>> <surefire.version>2.17</surefire.version>
>> >>> </properties>
>> >>>
>> >>>
>> >
>> > --
>> > Andrew Gaul
>> > http://gaul.org/
>
>--
>Andrew Gaul
>http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Gaul <ga...@apache.org>.
Everyone will have their own opinion on this, but raising the bar with
consensus tends to lower the velocity of development and quantity of
contributions. Gaining consensus for a dependency upgrade is far below
my bar for notifying others or desiring to be notified. If a given
commit causes a regression, we can always revert it.
On Thu, Jun 19, 2014 at 07:06:42PM +0000, Everett Toews wrote:
> Agreed that commit-then-review is fine for smaller changes but this doesn’t fall into that category.
>
> The okhttp.version affects downstream modules (e.g. openstack-marconi) and changing that version could break those downstream modules. I don’t classify that as a small change.
>
> Also, committing directly to the ASF git repo circumvents the CI jobs when a pull request is made in GitHub. Those jobs could catch any obvious problems and provide a layer of protection from breaking the build.
>
> I completely understand the desire to move fast on some of this stuff. It would be nice if you could give those of us who are maintaining downstream modules a heads up on IRC or via email.
>
> Regards,
> Everett
>
>
> On Jun 19, 2014, at 12:30 PM, Andrew Gaul <ga...@apache.org> wrote:
>
> > Committers are free to use commit-then-review or review-then-commit. I
> > often use the former for smaller changes.
> >
> > On Thu, Jun 19, 2014 at 02:48:24PM +0000, Everett Toews wrote:
> >> Where’s the pull request for this?
> >>
> >> Everett
> >>
> >>
> >> On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
> >>
> >>> Repository: jclouds
> >>> Updated Branches:
> >>> refs/heads/master 1982626cd -> ad56db2a4
> >>>
> >>>
> >>> Upgrade to OkHttp 1.6.0
> >>>
> >>> This upgrades both drivers/okhttp and mockwebserver. Changelog:
> >>>
> >>> https://github.com/square/okhttp/blob/master/CHANGELOG.md
> >>>
> >>>
> >>> Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> >>> Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> >>> Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> >>> Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
> >>>
> >>> Branch: refs/heads/master
> >>> Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> >>> Parents: 1982626
> >>> Author: Andrew Gaul <ga...@apache.org>
> >>> Authored: Wed Jun 18 19:41:46 2014 -0700
> >>> Committer: Andrew Gaul <ga...@apache.org>
> >>> Committed: Wed Jun 18 19:49:50 2014 -0700
> >>>
> >>> ----------------------------------------------------------------------
> >>> project/pom.xml | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>> ----------------------------------------------------------------------
> >>>
> >>>
> >>> http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
> >>> ----------------------------------------------------------------------
> >>> diff --git a/project/pom.xml b/project/pom.xml
> >>> index 2d3b651..4b259d0 100644
> >>> --- a/project/pom.xml
> >>> +++ b/project/pom.xml
> >>> @@ -201,7 +201,7 @@
> >>> <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
> >>> <test.ssh.keyfile />
> >>> <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
> >>> - <okhttp.version>1.3.0</okhttp.version>
> >>> + <okhttp.version>1.6.0</okhttp.version>
> >>> <surefire.version>2.17</surefire.version>
> >>> </properties>
> >>>
> >>>
> >
> > --
> > Andrew Gaul
> > http://gaul.org/
--
Andrew Gaul
http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Everett Toews <ev...@RACKSPACE.COM>.
Agreed that commit-then-review is fine for smaller changes but this doesn’t fall into that category.
The okhttp.version affects downstream modules (e.g. openstack-marconi) and changing that version could break those downstream modules. I don’t classify that as a small change.
Also, committing directly to the ASF git repo circumvents the CI jobs when a pull request is made in GitHub. Those jobs could catch any obvious problems and provide a layer of protection from breaking the build.
I completely understand the desire to move fast on some of this stuff. It would be nice if you could give those of us who are maintaining downstream modules a heads up on IRC or via email.
Regards,
Everett
On Jun 19, 2014, at 12:30 PM, Andrew Gaul <ga...@apache.org> wrote:
> Committers are free to use commit-then-review or review-then-commit. I
> often use the former for smaller changes.
>
> On Thu, Jun 19, 2014 at 02:48:24PM +0000, Everett Toews wrote:
>> Where’s the pull request for this?
>>
>> Everett
>>
>>
>> On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
>>
>>> Repository: jclouds
>>> Updated Branches:
>>> refs/heads/master 1982626cd -> ad56db2a4
>>>
>>>
>>> Upgrade to OkHttp 1.6.0
>>>
>>> This upgrades both drivers/okhttp and mockwebserver. Changelog:
>>>
>>> https://github.com/square/okhttp/blob/master/CHANGELOG.md
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
>>> Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
>>> Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
>>>
>>> Branch: refs/heads/master
>>> Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
>>> Parents: 1982626
>>> Author: Andrew Gaul <ga...@apache.org>
>>> Authored: Wed Jun 18 19:41:46 2014 -0700
>>> Committer: Andrew Gaul <ga...@apache.org>
>>> Committed: Wed Jun 18 19:49:50 2014 -0700
>>>
>>> ----------------------------------------------------------------------
>>> project/pom.xml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
>>> ----------------------------------------------------------------------
>>> diff --git a/project/pom.xml b/project/pom.xml
>>> index 2d3b651..4b259d0 100644
>>> --- a/project/pom.xml
>>> +++ b/project/pom.xml
>>> @@ -201,7 +201,7 @@
>>> <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
>>> <test.ssh.keyfile />
>>> <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
>>> - <okhttp.version>1.3.0</okhttp.version>
>>> + <okhttp.version>1.6.0</okhttp.version>
>>> <surefire.version>2.17</surefire.version>
>>> </properties>
>>>
>>>
>
> --
> Andrew Gaul
> http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Gaul <ga...@apache.org>.
Committers are free to use commit-then-review or review-then-commit. I
often use the former for smaller changes.
On Thu, Jun 19, 2014 at 02:48:24PM +0000, Everett Toews wrote:
> Where’s the pull request for this?
>
> Everett
>
>
> On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
>
> > Repository: jclouds
> > Updated Branches:
> > refs/heads/master 1982626cd -> ad56db2a4
> >
> >
> > Upgrade to OkHttp 1.6.0
> >
> > This upgrades both drivers/okhttp and mockwebserver. Changelog:
> >
> > https://github.com/square/okhttp/blob/master/CHANGELOG.md
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> > Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> > Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
> >
> > Branch: refs/heads/master
> > Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> > Parents: 1982626
> > Author: Andrew Gaul <ga...@apache.org>
> > Authored: Wed Jun 18 19:41:46 2014 -0700
> > Committer: Andrew Gaul <ga...@apache.org>
> > Committed: Wed Jun 18 19:49:50 2014 -0700
> >
> > ----------------------------------------------------------------------
> > project/pom.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/project/pom.xml b/project/pom.xml
> > index 2d3b651..4b259d0 100644
> > --- a/project/pom.xml
> > +++ b/project/pom.xml
> > @@ -201,7 +201,7 @@
> > <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
> > <test.ssh.keyfile />
> > <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
> > - <okhttp.version>1.3.0</okhttp.version>
> > + <okhttp.version>1.6.0</okhttp.version>
> > <surefire.version>2.17</surefire.version>
> > </properties>
> >
> >
--
Andrew Gaul
http://gaul.org/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Andrew Phillips <ap...@qrmedia.com>.
> I think this is the one you are looking for:
> https://github.com/jclouds/jclouds/pull/413
That PR proposes a different change which, from what I understand, is
dependent on the updated OkHttp version.
I think Everett is referring to this commit [1], for which there
doesn't seem to have been a PR - at least, I can't see one.
The CI build for this change [2] only had an unrelated test failure
[3] at the point when it failed due to some Nexus problem (I don't
know if the change caused failures in any downstream CI builds).
I'd like to do a full CI build with no Nexus problems to see what the
status is...working on that now...
ap
[1]
https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
[2] https://jclouds.ci.cloudbees.com/job/jclouds/2636/changes
[3] https://jclouds.ci.cloudbees.com/job/jclouds/2636/testReport/
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Roman Coedo <ro...@gmail.com>.
I think this is the one you are looking for:
https://github.com/jclouds/jclouds/pull/413
2014-06-19 16:48 GMT+02:00 Everett Toews <ev...@rackspace.com>:
> Where’s the pull request for this?
>
> Everett
>
>
> On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
>
> > Repository: jclouds
> > Updated Branches:
> > refs/heads/master 1982626cd -> ad56db2a4
> >
> >
> > Upgrade to OkHttp 1.6.0
> >
> > This upgrades both drivers/okhttp and mockwebserver. Changelog:
> >
> > https://github.com/square/okhttp/blob/master/CHANGELOG.md
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> > Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> > Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
> >
> > Branch: refs/heads/master
> > Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> > Parents: 1982626
> > Author: Andrew Gaul <ga...@apache.org>
> > Authored: Wed Jun 18 19:41:46 2014 -0700
> > Committer: Andrew Gaul <ga...@apache.org>
> > Committed: Wed Jun 18 19:49:50 2014 -0700
> >
> > ----------------------------------------------------------------------
> > project/pom.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/project/pom.xml b/project/pom.xml
> > index 2d3b651..4b259d0 100644
> > --- a/project/pom.xml
> > +++ b/project/pom.xml
> > @@ -201,7 +201,7 @@
> >
> <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
> > <test.ssh.keyfile />
> >
> <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
> > - <okhttp.version>1.3.0</okhttp.version>
> > + <okhttp.version>1.6.0</okhttp.version>
> > <surefire.version>2.17</surefire.version>
> > </properties>
> >
> >
>
>
Re: git commit: Upgrade to OkHttp 1.6.0
Posted by Everett Toews <ev...@RACKSPACE.COM>.
Where’s the pull request for this?
Everett
On Jun 18, 2014, at 9:50 PM, gaul@apache.org wrote:
> Repository: jclouds
> Updated Branches:
> refs/heads/master 1982626cd -> ad56db2a4
>
>
> Upgrade to OkHttp 1.6.0
>
> This upgrades both drivers/okhttp and mockwebserver. Changelog:
>
> https://github.com/square/okhttp/blob/master/CHANGELOG.md
>
>
> Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
> Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad56db2a
> Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad56db2a
> Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad56db2a
>
> Branch: refs/heads/master
> Commit: ad56db2a4d6ac4c3b7b126ba4303ab6e0c1f8b5e
> Parents: 1982626
> Author: Andrew Gaul <ga...@apache.org>
> Authored: Wed Jun 18 19:41:46 2014 -0700
> Committer: Andrew Gaul <ga...@apache.org>
> Committed: Wed Jun 18 19:49:50 2014 -0700
>
> ----------------------------------------------------------------------
> project/pom.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad56db2a/project/pom.xml
> ----------------------------------------------------------------------
> diff --git a/project/pom.xml b/project/pom.xml
> index 2d3b651..4b259d0 100644
> --- a/project/pom.xml
> +++ b/project/pom.xml
> @@ -201,7 +201,7 @@
> <jclouds.test.listener>org.jclouds.test.testng.UnitTestStatusListener</jclouds.test.listener>
> <test.ssh.keyfile />
> <sourceReleaseAssemblyDescriptor>source-release-zip-tar</sourceReleaseAssemblyDescriptor>
> - <okhttp.version>1.3.0</okhttp.version>
> + <okhttp.version>1.6.0</okhttp.version>
> <surefire.version>2.17</surefire.version>
> </properties>
>
>