You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Denis Stepanov (Created) (JIRA)" <ji...@apache.org> on 2012/03/14 14:00:39 UTC

[jira] [Created] (TAP5-1873) JavaScript execution exception is not logged

JavaScript execution exception is not logged
--------------------------------------------

                 Key: TAP5-1873
                 URL: https://issues.apache.org/jira/browse/TAP5-1873
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3
            Reporter: Denis Stepanov


If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.

Tapestry.js ajaxRequest @453:

finalOptions.get('onException').call(this, response);

Should be:

finalOptions.get('onException').call(this, response, e);

Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.

Tapestry.js ajaxExceptionHandler @371:

        Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
        if(exception.stack) {
    	   Tapestry.debug(exception.stack);
        }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1873) JavaScript execution exception is not logged

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1873:
------------------------------------------

    Assignee: Howard M. Lewis Ship
    
> JavaScript execution exception is not logged
> --------------------------------------------
>
>                 Key: TAP5-1873
>                 URL: https://issues.apache.org/jira/browse/TAP5-1873
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>            Assignee: Howard M. Lewis Ship
>
> If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.
> Tapestry.js ajaxRequest @453:
> finalOptions.get('onException').call(this, response);
> Should be:
> finalOptions.get('onException').call(this, response, e);
> Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.
> Tapestry.js ajaxExceptionHandler @371:
>         Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
>         if(exception.stack) {
>     	   Tapestry.debug(exception.stack);
>         }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1873) JavaScript execution exception is not logged

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1873:
------------------------------------------

    Assignee: Howard M. Lewis Ship
    
> JavaScript execution exception is not logged
> --------------------------------------------
>
>                 Key: TAP5-1873
>                 URL: https://issues.apache.org/jira/browse/TAP5-1873
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>            Assignee: Howard M. Lewis Ship
>
> If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.
> Tapestry.js ajaxRequest @453:
> finalOptions.get('onException').call(this, response);
> Should be:
> finalOptions.get('onException').call(this, response, e);
> Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.
> Tapestry.js ajaxExceptionHandler @371:
>         Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
>         if(exception.stack) {
>     	   Tapestry.debug(exception.stack);
>         }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1873) JavaScript execution exception is not logged

Posted by "Denis Stepanov (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232545#comment-13232545 ] 

Denis Stepanov commented on TAP5-1873:
--------------------------------------

Should I create a patch or the description is enough? It's only few lines of code.
                
> JavaScript execution exception is not logged
> --------------------------------------------
>
>                 Key: TAP5-1873
>                 URL: https://issues.apache.org/jira/browse/TAP5-1873
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>
> If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.
> Tapestry.js ajaxRequest @453:
> finalOptions.get('onException').call(this, response);
> Should be:
> finalOptions.get('onException').call(this, response, e);
> Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.
> Tapestry.js ajaxExceptionHandler @371:
>         Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
>         if(exception.stack) {
>     	   Tapestry.debug(exception.stack);
>         }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1873) JavaScript execution exception is not logged

Posted by "Denis Stepanov (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232545#comment-13232545 ] 

Denis Stepanov commented on TAP5-1873:
--------------------------------------

Should I create a patch or the description is enough? It's only few lines of code.
                
> JavaScript execution exception is not logged
> --------------------------------------------
>
>                 Key: TAP5-1873
>                 URL: https://issues.apache.org/jira/browse/TAP5-1873
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>
> If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.
> Tapestry.js ajaxRequest @453:
> finalOptions.get('onException').call(this, response);
> Should be:
> finalOptions.get('onException').call(this, response, e);
> Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.
> Tapestry.js ajaxExceptionHandler @371:
>         Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
>         if(exception.stack) {
>     	   Tapestry.debug(exception.stack);
>         }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1873) JavaScript execution exception is not logged

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1873.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.4
                   5.3.4
    
> JavaScript execution exception is not logged
> --------------------------------------------
>
>                 Key: TAP5-1873
>                 URL: https://issues.apache.org/jira/browse/TAP5-1873
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3.4, 5.4
>
>
> If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.
> Tapestry.js ajaxRequest @453:
> finalOptions.get('onException').call(this, response);
> Should be:
> finalOptions.get('onException').call(this, response, e);
> Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.
> Tapestry.js ajaxExceptionHandler @371:
>         Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
>         if(exception.stack) {
>     	   Tapestry.debug(exception.stack);
>         }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1873) JavaScript execution exception is not logged

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1873.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.4
                   5.3.4
    
> JavaScript execution exception is not logged
> --------------------------------------------
>
>                 Key: TAP5-1873
>                 URL: https://issues.apache.org/jira/browse/TAP5-1873
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3.4, 5.4
>
>
> If there is an error durring the ajax javascript execution, exception is not logged, that is a critical issue when you are developing and tracking errors.
> Tapestry.js ajaxRequest @453:
> finalOptions.get('onException').call(this, response);
> Should be:
> finalOptions.get('onException').call(this, response, e);
> Exception's stacktrace should be also logged otherwise there is no way to tell were did it came from.
> Tapestry.js ajaxExceptionHandler @371:
>         Tapestry.debug(Tapestry.Messages.ajaxFailure + exception, response);
>         if(exception.stack) {
>     	   Tapestry.debug(exception.stack);
>         }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira