[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2258: Ref gitlab conn id mr commit-4

[GitBox <gi...@apache.org>]

likyh commented on code in PR #2258:
URL: https://github.com/apache/incubator-devlake/pull/2258#discussion_r901250087


##########
plugins/gitlab/e2e/snapshot_tables/commits.csv:
##########
@@ -1,64 +1 @@
 sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark,additions,deletions,dev_eq,message,author_name,author_email,authored_date,author_id,committer_name,committer_email,committed_date,committer_id
-03b566ec2af3106808f385dacdbd3edf54f4c2c4,"{""ConnectionId"":1,""ProjectId"":20171709}",_raw_gitlab_api_commit,3,,7,1,0,"update README.md

Review Comment:
   Is empty csv right? There are some commits in _tool_gitlab_commits.csv



##########
plugins/gitlab/e2e/mr_commits_test.go:
##########
@@ -39,19 +39,64 @@ func TestGitlabCommitDataFlow(t *testing.T) {
 			ProjectId:    20171709,
 		},
 	}
+
+	// Prepare _tool_gitlab_pull_requests for mr_commit convertor test
+	err := dataflowTester.Db.Migrator().DropTable("_raw_gitlab_api_merge_requests")

Review Comment:
   it's not necessary. Because `ImportCsvIntoRawTable` dropped.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org