You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@openjpa.apache.org by kw...@apache.org on 2010/02/23 19:35:45 UTC

svn commit: r915472 - /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreManager.java

Author: kwsutter
Date: Tue Feb 23 18:35:44 2010
New Revision: 915472

URL: http://svn.apache.org/viewvc?rev=915472&view=rev
Log:
OPENJPA-1516.  Additional comments on the free() method to indicate that callers need to ensure thread-safety.

Modified:
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreManager.java

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreManager.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreManager.java?rev=915472&r1=915471&r2=915472&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreManager.java (original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/JDBCStoreManager.java Tue Feb 23 18:35:44 2010
@@ -1530,6 +1530,9 @@
             }
         }
 
+        /*
+         * Non-thread-safe method.  Ensure protection in the call path...
+         */
         public void free() {
             // ensure that we do not close the underlying connection
             // multiple times; this could happen if someone (e.g., an