You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2024/08/06 12:57:52 UTC
[PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
m1a2st opened a new pull request, #16810:
URL: https://github.com/apache/kafka/pull/16810
Due to this test is too slow, it can't test in 30 seconds. Thus I add a config to speed up this test, let it can completed in 30s
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2304037032
With merging this PR we can keep testing the global timeout for all IT (#16957)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2275698407
Thanks for your comments, however I watch the kafka document
> A new config, group.initial.rebalance.delay.ms was introduced. This config specifies the time, in milliseconds, that the GroupCoordinator will delay the initial consumer rebalance. The rebalance will be further delayed by the value of group.initial.rebalance.delay.ms as new members join the group, up to a maximum of max.poll.interval.ms. The default value for this is 3 seconds. During development and testing it might be desirable to set this to 0 in order to not delay test execution time.
According to the document, I consider that these tests are suitable for this config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16810:
URL: https://github.com/apache/kafka/pull/16810#discussion_r1713087922
##########
core/src/test/scala/integration/kafka/server/KafkaServerKRaftRegistrationTest.scala:
##########
@@ -41,7 +41,7 @@ import scala.jdk.CollectionConverters._
* failure paths is to use timeouts. See {@link unit.kafka.server.BrokerRegistrationRequestTest} for integration test
* of just the broker registration path.
*/
-@Timeout(120)
+@Timeout(30)
Review Comment:
please revert this unrelated change
##########
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##########
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.extension.ExtendWith
import scala.jdk.CollectionConverters._
-@Timeout(120)
+@Timeout(30)
Review Comment:
please revert this unrelated change
##########
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##########
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Timeout
import org.junit.jupiter.api.extension.ExtendWith
-@Timeout(120)
+@Timeout(30)
Review Comment:
please revert this unrelated change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #16810:
URL: https://github.com/apache/kafka/pull/16810#discussion_r1708188454
##########
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##########
@@ -36,13 +36,14 @@ import scala.concurrent.duration.Duration
import scala.concurrent.{Await, Future}
import scala.jdk.CollectionConverters._
-@Timeout(120)
+@Timeout(30)
@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinatorBaseRequestTest(cluster) {
@ClusterTest(types = Array(Type.KRAFT), serverProperties = Array(
new ClusterConfigProperty(key = "group.coordinator.new.enable", value = "true"),
new ClusterConfigProperty(key = "offsets.topic.num.partitions", value = "1"),
- new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1")
+ new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1"),
+ new ClusterConfigProperty(key = "group.initial.rebalance.delay.ms", value = "0"),
Review Comment:
You are right, but we test these tests without add `group.initial.rebalance.delay.ms` and find a problem that Kraft mode is obviously slower than Zookeeper mode, thus we guess that root cause is the metadata synchronization speed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #16810:
URL: https://github.com/apache/kafka/pull/16810#discussion_r1718631839
##########
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##########
@@ -51,7 +52,8 @@ class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinatorBas
@ClusterTest(serverProperties = Array(
new ClusterConfigProperty(key = "group.coordinator.new.enable", value = "false"),
new ClusterConfigProperty(key = "offsets.topic.num.partitions", value = "1"),
- new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1")
+ new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1"),
+ new ClusterConfigProperty(key = "group.initial.rebalance.delay.ms", value = "1"),
Review Comment:
Yes, the unit is ms, I fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2297822862
Yes, Becasue It is Zookeeper mode test, the config `group.initial.rebalance.delay.ms` in zookeeper mode default is 0 [setting], thus In this case we transfer to 1000 is slower than before. In KRaft mode it doesn't init the config value, thus the defulat value is 3000.
[setting]: https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/utils/TestUtils.scala#L354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2275568303
@m1a2st Thanks for the patch. I understand the motivation but I wonder if it is a good choice. If we change the configuration, it means that the integration test won’t cover the initial rebalance delay which is the default behavior. I think that we should rather keep it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2282728056
@m1a2st could you please revise the title? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16810:
URL: https://github.com/apache/kafka/pull/16810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2297803103
@m1a2st there are some tests getting slower. `testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator`, `testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator`, and `testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator`. Do you know the root cause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2303806596
@m1a2st please fix conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2297829831
@m1a2st could you please rebase code to trigger QA again? there are many failed tests. I feel they are unrelated, but double-check is not bad thing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2297832075
I have rebased it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #16810:
URL: https://github.com/apache/kafka/pull/16810#discussion_r1708188454
##########
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##########
@@ -36,13 +36,14 @@ import scala.concurrent.duration.Duration
import scala.concurrent.{Await, Future}
import scala.jdk.CollectionConverters._
-@Timeout(120)
+@Timeout(30)
@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinatorBaseRequestTest(cluster) {
@ClusterTest(types = Array(Type.KRAFT), serverProperties = Array(
new ClusterConfigProperty(key = "group.coordinator.new.enable", value = "true"),
new ClusterConfigProperty(key = "offsets.topic.num.partitions", value = "1"),
- new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1")
+ new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1"),
+ new ClusterConfigProperty(key = "group.initial.rebalance.delay.ms", value = "0"),
Review Comment:
You are right, but we test these test without add `group.initial.rebalance.delay.ms` and find a problem that Kraft mode is obviously slower than Zookeeper mode, thus we guess that root cause is the metadata synchronization speed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2295490873
The test results:
- `JoinGroupRequestTest`
- `ListGroupsRequestTest`
- `SyncGroupRequestTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2297828173
> thus In these cases that we transfer to 1000 is slower than before. In KRaft mode it doesn't init the config value, thus the defulat value is 3000.
makes sense. LGTM. will merge it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2295286578
@m1a2st could you please share the results again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2276564430
The test sends many `JoinGroupRequest` and each request needs to wait delay ("3" seconds). Also, the zk mode runs so fast due to initial_delay=0 (see following link)
https://github.com/apache/kafka/blob/e7317b37bf4a3ea5beaeb22a9b0707bdb16ebee7/core/src/test/scala/unit/kafka/utils/TestUtils.scala#L352
Maybe we can reduce the delay from 3 seconds to 1.5 seconds? That not only keep the initial rebalance delay but also speed up the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2282945825
@chia7712, Thanks for your comments, revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on code in PR #16810:
URL: https://github.com/apache/kafka/pull/16810#discussion_r1707722728
##########
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##########
@@ -36,13 +36,14 @@ import scala.concurrent.duration.Duration
import scala.concurrent.{Await, Future}
import scala.jdk.CollectionConverters._
-@Timeout(120)
+@Timeout(30)
@ExtendWith(value = Array(classOf[ClusterTestExtensions]))
class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinatorBaseRequestTest(cluster) {
@ClusterTest(types = Array(Type.KRAFT), serverProperties = Array(
new ClusterConfigProperty(key = "group.coordinator.new.enable", value = "true"),
new ClusterConfigProperty(key = "offsets.topic.num.partitions", value = "1"),
- new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1")
+ new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1"),
+ new ClusterConfigProperty(key = "group.initial.rebalance.delay.ms", value = "0"),
Review Comment:
Interesting finding, makes sense to me for the test. I expect it would it be helpful to add it also in the other test in this file, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2282369283
- KafkaServerKRaftRegistrationTest
- Before:
- After:
- ConsumerProtocolMigrationTest
- Before:
- After:
- JoinGroupRequestTest
- Before:
- After:
- ListGroupsRequestTest
- Before:
- After:
- OffsetFetchRequestTest
- Before:
- After:
- SyncGroupRequestTest
- Before:
- After:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16810:
URL: https://github.com/apache/kafka/pull/16810#discussion_r1718603603
##########
core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala:
##########
@@ -51,7 +52,8 @@ class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinatorBas
@ClusterTest(serverProperties = Array(
new ClusterConfigProperty(key = "group.coordinator.new.enable", value = "false"),
new ClusterConfigProperty(key = "offsets.topic.num.partitions", value = "1"),
- new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1")
+ new ClusterConfigProperty(key = "offsets.topic.replication.factor", value = "1"),
+ new ClusterConfigProperty(key = "group.initial.rebalance.delay.ms", value = "1"),
Review Comment:
it should be "1000" rather than "1"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2297759514
The test results compare:
- `JoinGroupRequestTest`
- Before
| test name | type | time |
|---|---|---|
| JoinGroupRequestTest | | 3m 21s
| testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 33s 328ms
| testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［1］ Type=ZK, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 2s 597ms
| testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［2］ Type=Raft-Isolated, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 32s 596ms
| testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［3］ Type=Raft-Combined, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 31s 986ms
- After
| test name | type | time |
|---|---|---|
| JoinGroupRequestTest | | 1m 43s
| testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 13s 557ms
| testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［1］ Type=ZK, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 13s 49ms
| testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［2］ Type=Raft-Isolated, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 12s 324ms
| testJoinGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［3］ Type=Raft-Combined, MetadataVersion=4.0-IV1,Security=PLAINTEXT | 12s 329ms
- `ListGroupsRequestTest`
- Before
| test name | type | time |
|---|---|---|
| ListGroupsRequestTest | | 7min 31s
| testListGroupsWithNewConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 57s 215ms
| testListGroupsWithOldConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 55s 929ms
| testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator |［1］ Type=ZK, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 1s 731ms
| testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［2］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 55s 362ms
| testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator | '［3］ Type=Raft-Combined, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 55s 3ms
- After
| test name | type | time |
|---|---|---|
| ListGroupsRequestTest | | 3min 18s
| testListGroupsWithNewConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 21s 428ms
| testListGroupsWithOldConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 19s 735ms
| testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator |［1］ Type=ZK, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 20s 32ms
| testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［2］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 19s 34ms
| testListGroupsWithOldConsumerGroupProtocolAndOldGroupCoordinator | '［3］ Type=Raft-Combined, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 18s 945ms
- `SyncGroupRequestTest`
- Before
| test name | type | time |
|---|---|---|
| SyncGroupRequestTest | | 2m 3s
| testSyncGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 20s 411ms
| testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［1］ Type=ZK, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 1s 849ms
| testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［2］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 19s 753ms
| testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［3］ Type=Raft-Combined, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 19s 555ms
- After
| test name | type | time |
|---|---|---|
| SyncGroupRequestTest | | 1m 4s
| testSyncGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator | ［1］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 8s 587ms
| testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［1］ Type=ZK, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 8s 248ms
| testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［2］ Type=Raft-Isolated, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 7s 728ms
| testSyncGroupWithOldConsumerGroupProtocolAndOldGroupCoordinator | ［3］ Type=Raft-Combined, MetadataVersion=4.0-IVO,Security=PLAINTEXT | 7s 374ms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2282727964
> According to the above test results, I consider we should modify JoinGroupRequestTest, ListGroupsRequestTest and SyncGroupRequestTest by add group.initial.rebalance.delay.ms config
that makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2282245551
@m1a2st Could you please share the "before" and "after"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest#testJoinGroupWithOldConsumerGroupProtocolAndNewGroupCoordinator [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2282370083
According to the above test results, I consider we should modify `JoinGroupRequestTest`, `ListGroupsRequestTest` and `SyncGroupRequestTest` by add `group.initial.rebalance.delay.ms` config, and others should reduce the timeout from 120s to 30s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #16810:
URL: https://github.com/apache/kafka/pull/16810#issuecomment-2303829318
Thanks for your comments. I resolve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org