You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Sven Reimers <sv...@gmail.com> on 2018/04/23 18:54:08 UTC
PR for issue 4444 (Aqua look and feel broken on JDK10 / 11)
Hi all,
Since the above issue (https://issues.apache.org/jira/browse/NETBEANS-444)
is bad for all OS X users already having installed Java 10, I tried to fix
this.
The relevant PR is https://github.com/apache/incubator-netbeans/pull/516
For trying out you can just clone and build my branch from
https://github.com/svenreimers/incubator-netbeans/tree/netbeans-444.
Hope anyone can confirm the fix so we can merge the PR before release (or
RC).
Thanks
Sven
Re: PR for issue 4444 (Aqua look and feel broken on JDK10 / 11)
Posted by Sven Reimers <sv...@gmail.com>.
@Emilian - good idea - just wanted to make the smallest possible change at
this stage of the release process...
Sven
On Mon, Apr 23, 2018 at 9:47 PM, John McDonnell <mc...@gmail.com>
wrote:
> Don't have Java9 or 10, but managed to check out this PR on Java 8 on my
> mac.
>
> No issues spotted either in the logs upon startup or changing the LnF's.
>
> Regards
>
> John
>
> On 23 April 2018 at 20:13, Emilian Bold <em...@protonmail.ch>
> wrote:
>
> > Then it should be an easy +1.
> >
> > Still, having that LnF name copy-pasted everywhere... Perhaps we do need
> > some isAquaLnF method.
> >
> > --emi
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On 23 April 2018 10:11 PM, Sven Reimers <sv...@gmail.com> wrote:
> >
> > > Runs on 8,9,10,11..
> > >
> > > It is just a simple fix - use the new LnF name instead the old one. The
> > new
> > >
> > > name is already available in 8...
> > >
> > > Sven
> > >
> > > On Mon, Apr 23, 2018 at 9:08 PM, Emilian Bold
> emilian.bold@protonmail.ch
> > >
> > > wrote:
> > >
> > > > I'll comment on GitHub too when I'm logged in there.
> > > >
> > > > Does this fix run on Java 8? Or is it Java 10 specific? If it's
> > specific
> > > >
> > > > shouldn't we keep checking which JRE are we running on?
> > > >
> > > > Perhaps some BaseUtilities.isAquaLnF method would help?
> > > >
> > > > --emi
> > > >
> > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > >
> > > > On 23 April 2018 9:54 PM, Sven Reimers sven.reimers@gmail.com wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > Since the above issue (https://issues.apache.org/
> > > > >
> > > > > jira/browse/NETBEANS-444)
> > > > >
> > > > > is bad for all OS X users already having installed Java 10, I tried
> > to
> > > > >
> > > > > fix
> > > > >
> > > > > this.
> > > > >
> > > > > The relevant PR is https://github.com/apache/
> > incubator-netbeans/pull/516
> > > > >
> > > > > For trying out you can just clone and build my branch from
> > > > >
> > > > > https://github.com/svenreimers/incubator-
> netbeans/tree/netbeans-444.
> > > > >
> > > > > Hope anyone can confirm the fix so we can merge the PR before
> > release (or
> > > > >
> > > > > RC).
> > > > >
> > > > > Thanks
> > > > >
> > > > > Sven
> > > >
> > > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.
> incubator.apache.org
> > > >
> > > > For additional commands, e-mail: dev-help@netbeans.incubator.
> > apache.org
> > > >
> > > > For further information about the NetBeans mailing lists, visit:
> > > >
> > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > >
> > > --
> > >
> > > Sven Reimers
> > >
> > > - Senior Expert Software Architect
> > > - Java Champion
> > > - NetBeans Dream Team Member: http://dreamteam.netbeans.org
> > > - Community Leader NetBeans: http://community.java.net/netbeans
> > >
> > > Desktop Java:
> > >
> > > http://community.java.net/javadesktop
> > >
> > > - JUG Leader JUG Bodensee: http://www.jug-bodensee.de
> > > - Duke's Choice Award Winner 2009
> > > - XING: https://www.xing.com/profile/Sven_Reimers8
> > > - LinkedIn: http://www.linkedin.com/in/svenreimers
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
>
--
Sven Reimers
* Senior Expert Software Architect
* Java Champion
* NetBeans Dream Team Member: http://dreamteam.netbeans.org
* Community Leader NetBeans: http://community.java.net/netbeans
Desktop Java:
http://community.java.net/javadesktop
* JUG Leader JUG Bodensee: http://www.jug-bodensee.de
* Duke's Choice Award Winner 2009
* XING: https://www.xing.com/profile/Sven_Reimers8
* LinkedIn: http://www.linkedin.com/in/svenreimers
Re: PR for issue 4444 (Aqua look and feel broken on JDK10 / 11)
Posted by John McDonnell <mc...@gmail.com>.
Don't have Java9 or 10, but managed to check out this PR on Java 8 on my
mac.
No issues spotted either in the logs upon startup or changing the LnF's.
Regards
John
On 23 April 2018 at 20:13, Emilian Bold <em...@protonmail.ch> wrote:
> Then it should be an easy +1.
>
> Still, having that LnF name copy-pasted everywhere... Perhaps we do need
> some isAquaLnF method.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 23 April 2018 10:11 PM, Sven Reimers <sv...@gmail.com> wrote:
>
> > Runs on 8,9,10,11..
> >
> > It is just a simple fix - use the new LnF name instead the old one. The
> new
> >
> > name is already available in 8...
> >
> > Sven
> >
> > On Mon, Apr 23, 2018 at 9:08 PM, Emilian Bold emilian.bold@protonmail.ch
> >
> > wrote:
> >
> > > I'll comment on GitHub too when I'm logged in there.
> > >
> > > Does this fix run on Java 8? Or is it Java 10 specific? If it's
> specific
> > >
> > > shouldn't we keep checking which JRE are we running on?
> > >
> > > Perhaps some BaseUtilities.isAquaLnF method would help?
> > >
> > > --emi
> > >
> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > >
> > > On 23 April 2018 9:54 PM, Sven Reimers sven.reimers@gmail.com wrote:
> > >
> > > > Hi all,
> > > >
> > > > Since the above issue (https://issues.apache.org/
> > > >
> > > > jira/browse/NETBEANS-444)
> > > >
> > > > is bad for all OS X users already having installed Java 10, I tried
> to
> > > >
> > > > fix
> > > >
> > > > this.
> > > >
> > > > The relevant PR is https://github.com/apache/
> incubator-netbeans/pull/516
> > > >
> > > > For trying out you can just clone and build my branch from
> > > >
> > > > https://github.com/svenreimers/incubator-netbeans/tree/netbeans-444.
> > > >
> > > > Hope anyone can confirm the fix so we can merge the PR before
> release (or
> > > >
> > > > RC).
> > > >
> > > > Thanks
> > > >
> > > > Sven
> > >
> > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > For additional commands, e-mail: dev-help@netbeans.incubator.
> apache.org
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > >
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> > --
> >
> > Sven Reimers
> >
> > - Senior Expert Software Architect
> > - Java Champion
> > - NetBeans Dream Team Member: http://dreamteam.netbeans.org
> > - Community Leader NetBeans: http://community.java.net/netbeans
> >
> > Desktop Java:
> >
> > http://community.java.net/javadesktop
> >
> > - JUG Leader JUG Bodensee: http://www.jug-bodensee.de
> > - Duke's Choice Award Winner 2009
> > - XING: https://www.xing.com/profile/Sven_Reimers8
> > - LinkedIn: http://www.linkedin.com/in/svenreimers
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: PR for issue 4444 (Aqua look and feel broken on JDK10 / 11)
Posted by Emilian Bold <em...@protonmail.ch>.
Then it should be an easy +1.
Still, having that LnF name copy-pasted everywhere... Perhaps we do need some isAquaLnF method.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 23 April 2018 10:11 PM, Sven Reimers <sv...@gmail.com> wrote:
> Runs on 8,9,10,11..
>
> It is just a simple fix - use the new LnF name instead the old one. The new
>
> name is already available in 8...
>
> Sven
>
> On Mon, Apr 23, 2018 at 9:08 PM, Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > I'll comment on GitHub too when I'm logged in there.
> >
> > Does this fix run on Java 8? Or is it Java 10 specific? If it's specific
> >
> > shouldn't we keep checking which JRE are we running on?
> >
> > Perhaps some BaseUtilities.isAquaLnF method would help?
> >
> > --emi
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On 23 April 2018 9:54 PM, Sven Reimers sven.reimers@gmail.com wrote:
> >
> > > Hi all,
> > >
> > > Since the above issue (https://issues.apache.org/
> > >
> > > jira/browse/NETBEANS-444)
> > >
> > > is bad for all OS X users already having installed Java 10, I tried to
> > >
> > > fix
> > >
> > > this.
> > >
> > > The relevant PR is https://github.com/apache/incubator-netbeans/pull/516
> > >
> > > For trying out you can just clone and build my branch from
> > >
> > > https://github.com/svenreimers/incubator-netbeans/tree/netbeans-444.
> > >
> > > Hope anyone can confirm the fix so we can merge the PR before release (or
> > >
> > > RC).
> > >
> > > Thanks
> > >
> > > Sven
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
> --
>
> Sven Reimers
>
> - Senior Expert Software Architect
> - Java Champion
> - NetBeans Dream Team Member: http://dreamteam.netbeans.org
> - Community Leader NetBeans: http://community.java.net/netbeans
>
> Desktop Java:
>
> http://community.java.net/javadesktop
>
> - JUG Leader JUG Bodensee: http://www.jug-bodensee.de
> - Duke's Choice Award Winner 2009
> - XING: https://www.xing.com/profile/Sven_Reimers8
> - LinkedIn: http://www.linkedin.com/in/svenreimers
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: PR for issue 4444 (Aqua look and feel broken on JDK10 / 11)
Posted by Sven Reimers <sv...@gmail.com>.
Runs on 8,9,10,11..
It is just a simple fix - use the new LnF name instead the old one. The new
name is already available in 8...
Sven
On Mon, Apr 23, 2018 at 9:08 PM, Emilian Bold <em...@protonmail.ch>
wrote:
> I'll comment on GitHub too when I'm logged in there.
>
> Does this fix run on Java 8? Or is it Java 10 specific? If it's specific
> shouldn't we keep checking which JRE are we running on?
>
> Perhaps some BaseUtilities.isAquaLnF method would help?
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 23 April 2018 9:54 PM, Sven Reimers <sv...@gmail.com> wrote:
>
> > Hi all,
> >
> > Since the above issue (https://issues.apache.org/
> jira/browse/NETBEANS-444)
> >
> > is bad for all OS X users already having installed Java 10, I tried to
> fix
> >
> > this.
> >
> > The relevant PR is https://github.com/apache/incubator-netbeans/pull/516
> >
> > For trying out you can just clone and build my branch from
> >
> > https://github.com/svenreimers/incubator-netbeans/tree/netbeans-444.
> >
> > Hope anyone can confirm the fix so we can merge the PR before release (or
> >
> > RC).
> >
> > Thanks
> >
> > Sven
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
--
Sven Reimers
* Senior Expert Software Architect
* Java Champion
* NetBeans Dream Team Member: http://dreamteam.netbeans.org
* Community Leader NetBeans: http://community.java.net/netbeans
Desktop Java:
http://community.java.net/javadesktop
* JUG Leader JUG Bodensee: http://www.jug-bodensee.de
* Duke's Choice Award Winner 2009
* XING: https://www.xing.com/profile/Sven_Reimers8
* LinkedIn: http://www.linkedin.com/in/svenreimers
Re: PR for issue 4444 (Aqua look and feel broken on JDK10 / 11)
Posted by Emilian Bold <em...@protonmail.ch>.
I'll comment on GitHub too when I'm logged in there.
Does this fix run on Java 8? Or is it Java 10 specific? If it's specific shouldn't we keep checking which JRE are we running on?
Perhaps some BaseUtilities.isAquaLnF method would help?
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 23 April 2018 9:54 PM, Sven Reimers <sv...@gmail.com> wrote:
> Hi all,
>
> Since the above issue (https://issues.apache.org/jira/browse/NETBEANS-444)
>
> is bad for all OS X users already having installed Java 10, I tried to fix
>
> this.
>
> The relevant PR is https://github.com/apache/incubator-netbeans/pull/516
>
> For trying out you can just clone and build my branch from
>
> https://github.com/svenreimers/incubator-netbeans/tree/netbeans-444.
>
> Hope anyone can confirm the fix so we can merge the PR before release (or
>
> RC).
>
> Thanks
>
> Sven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists